From 01a7e7893b2c2866dc39b8c688bd30f108610c4e Mon Sep 17 00:00:00 2001 From: tarui Date: Wed, 6 Nov 2013 12:36:34 +0000 Subject: * gc.c (gc_before_sweep): Change algorithm of malloc_limit to conservative for closing to memory consumption of ruby 2.0. * gc.c (GC_MALLOC_LIMIT, GC_MALLOC_LIMIT_GROWTH_FACTOR): Adjust parameters for new algorithm. Example: make gcbench-rdoc on a pc time maxrss 2.0.0p343 285.27 281853952 trunk before patch 207.19 690405376 trunk after patch 211.59 312500224 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43558 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- gc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'gc.c') diff --git a/gc.c b/gc.c index 7b4ae45343..8cb7687d5e 100644 --- a/gc.c +++ b/gc.c @@ -91,23 +91,23 @@ rb_gc_guarded_ptr(volatile VALUE *ptr) #endif #ifndef GC_MALLOC_LIMIT -#define GC_MALLOC_LIMIT (16 /* 16 MB */ * 1024 * 1024 /* 1MB */) +#define GC_MALLOC_LIMIT (8 * 1024 * 1024 /* 8MB */) #endif #ifndef GC_MALLOC_LIMIT_MAX -#define GC_MALLOC_LIMIT_MAX (384 /* 384 MB */ * 1024 * 1024 /* 1MB */) +#define GC_MALLOC_LIMIT_MAX (384 * 1024 * 1024 /* 384MB */) #endif #ifndef GC_MALLOC_LIMIT_GROWTH_FACTOR -#define GC_MALLOC_LIMIT_GROWTH_FACTOR 2.0 +#define GC_MALLOC_LIMIT_GROWTH_FACTOR 1.0 #endif #ifndef GC_HEAP_OLDSPACE_MIN -#define GC_HEAP_OLDSPACE_MIN (16 /* 16 MB */ * 1024 * 1024 /* 1MB */) +#define GC_HEAP_OLDSPACE_MIN (16 * 1024 * 1024 /* 16MB */) #endif #ifndef GC_HEAP_OLDSPACE_GROWTH_FACTOR #define GC_HEAP_OLDSPACE_GROWTH_FACTOR 1.8 #endif #ifndef GC_HEAP_OLDSPACE_MAX -#define GC_HEAP_OLDSPACE_MAX (384 /* 384 MB */ * 1024 * 1024 /* 1MB */) +#define GC_HEAP_OLDSPACE_MAX (384 * 1024 * 1024 /* 384MB */) #endif typedef struct { @@ -2812,14 +2812,14 @@ gc_before_sweep(rb_objspace_t *objspace) size_t old_limit = malloc_limit; if (inc > malloc_limit) { - malloc_limit += (size_t)(malloc_limit * (initial_malloc_limit_growth_factor - 1)); + malloc_limit = (size_t)(inc * initial_malloc_limit_growth_factor); if (initial_malloc_limit_max > 0 && /* ignore max-check if 0 */ malloc_limit > initial_malloc_limit_max) { malloc_limit = initial_malloc_limit_max; } } else { - malloc_limit -= (size_t)(malloc_limit * ((initial_malloc_limit_growth_factor - 1) / 10)); + malloc_limit = (size_t)(malloc_limit * 0.98); /* magic number */ if (malloc_limit < initial_malloc_limit) { malloc_limit = initial_malloc_limit; } -- cgit v1.2.3