From f641d78a6fcf0b96c50077503a763478d0599fe5 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Wed, 24 Jul 2019 16:01:20 -0400 Subject: [ruby/psych] Implement `freeze` option for Pysch.load https://github.com/ruby/psych/commit/7dae24894d --- ext/psych/lib/psych/visitors/to_ruby.rb | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'ext/psych/lib/psych/visitors/to_ruby.rb') diff --git a/ext/psych/lib/psych/visitors/to_ruby.rb b/ext/psych/lib/psych/visitors/to_ruby.rb index 68452e5c3e..a922f90831 100644 --- a/ext/psych/lib/psych/visitors/to_ruby.rb +++ b/ext/psych/lib/psych/visitors/to_ruby.rb @@ -32,16 +32,18 @@ module Psych def accept target result = super - return result if @domain_types.empty? || !target.tag - key = target.tag.sub(/^[!\/]*/, '').sub(/(,\d+)\//, '\1:') - key = "tag:#{key}" unless key =~ /^(?:tag:|x-private)/ + unless @domain_types.empty? || !target.tag + key = target.tag.sub(/^[!\/]*/, '').sub(/(,\d+)\//, '\1:') + key = "tag:#{key}" unless key =~ /^(?:tag:|x-private)/ - if @domain_types.key? key - value, block = @domain_types[key] - return block.call value, result + if @domain_types.key? key + value, block = @domain_types[key] + result = block.call value, result + end end + result = deduplicate(result).freeze if @freeze result end @@ -341,7 +343,7 @@ module Psych key = accept(k) if @symbolize_names key = key.to_sym - else + elsif !@freeze key = deduplicate(key) end val = accept(v) @@ -378,6 +380,8 @@ module Psych if RUBY_VERSION < '2.7' def deduplicate key if key.is_a?(String) + # It is important to untaint the string, otherwise it won't + # be deduplicated into an fstring, but simply frozen. -(key.untaint) else key -- cgit v1.2.3