From 451fe269e5ab1270a53ac7bdeceabe47fd431f95 Mon Sep 17 00:00:00 2001 From: nobu Date: Fri, 29 May 2015 05:55:02 +0000 Subject: openssl: wrapper object before alloc * ext/openssl: make wrapper objects before allocating structs to get rid of potential memory leaks. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50673 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ext/openssl/ossl_pkey_dsa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'ext/openssl/ossl_pkey_dsa.c') diff --git a/ext/openssl/ossl_pkey_dsa.c b/ext/openssl/ossl_pkey_dsa.c index 911342e144..b8e415dfa9 100644 --- a/ext/openssl/ossl_pkey_dsa.c +++ b/ext/openssl/ossl_pkey_dsa.c @@ -40,6 +40,7 @@ dsa_instance(VALUE klass, DSA *dsa) if (!dsa) { return Qfalse; } + obj = NewPKey(klass); if (!(pkey = EVP_PKEY_new())) { return Qfalse; } @@ -47,7 +48,7 @@ dsa_instance(VALUE klass, DSA *dsa) EVP_PKEY_free(pkey); return Qfalse; } - WrapPKey(klass, obj, pkey); + SetPKey(obj, pkey); return obj; } @@ -60,10 +61,11 @@ ossl_dsa_new(EVP_PKEY *pkey) if (!pkey) { obj = dsa_instance(cDSA, DSA_new()); } else { + obj = NewPKey(cDSA); if (EVP_PKEY_type(pkey->type) != EVP_PKEY_DSA) { ossl_raise(rb_eTypeError, "Not a DSA key!"); } - WrapPKey(cDSA, obj, pkey); + SetPKey(obj, pkey); } if (obj == Qfalse) { ossl_raise(eDSAError, NULL); -- cgit v1.2.3