From 12dfd9d1c980d17d8a0ea10bccb9cd7eca21b568 Mon Sep 17 00:00:00 2001 From: Ufuk Kayserilioglu Date: Mon, 25 Oct 2021 15:48:18 +0300 Subject: [flori/json] Call `super` in `included` hook The C extension defines an `included` hook for the `JSON::Ext::Generator::GeneratorMethods::String` module but neglects to call `super` in the hook. This can break the functionality of various other code that rely on the fact that `included` on `Module` will always be called. https://github.com/flori/json/commit/cd8bbe56a3 --- ext/json/generator/generator.c | 1 + 1 file changed, 1 insertion(+) (limited to 'ext/json') diff --git a/ext/json/generator/generator.c b/ext/json/generator/generator.c index 98d0ea46c3..8f7c57e042 100644 --- a/ext/json/generator/generator.c +++ b/ext/json/generator/generator.c @@ -478,6 +478,7 @@ static VALUE mFloat_to_json(int argc, VALUE *argv, VALUE self) */ static VALUE mString_included_s(VALUE self, VALUE modul) { VALUE result = rb_funcall(modul, i_extend, 1, mString_Extend); + rb_call_super(1, &modul); return result; } -- cgit v1.2.3