From 0381ab07694668c4420307a6d8e9f0265ed9c56d Mon Sep 17 00:00:00 2001 From: drbrain Date: Wed, 30 May 2012 23:41:07 +0000 Subject: * ext/dl/lib/dl/struct.rb (DL::CUnionEntity#set_ctypes): Refactored #set_types to reuse DL::CUnionEntity::size * test/dl/test_c_union_entity.rb: Added test Reviewed by Aaron Paterson git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ext/dl/lib/dl/struct.rb | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) (limited to 'ext/dl/lib/dl') diff --git a/ext/dl/lib/dl/struct.rb b/ext/dl/lib/dl/struct.rb index 23f28bbaa3..628adb21c2 100644 --- a/ext/dl/lib/dl/struct.rb +++ b/ext/dl/lib/dl/struct.rb @@ -242,19 +242,8 @@ module DL # Given +types+, calculate the necessary offset and for each union member def set_ctypes(types) @ctypes = types - @offset = [] - @size = 0 - types.each_with_index{|t,i| - @offset[i] = 0 - if( t.is_a?(Array) ) - size = SIZE_MAP[t[0]] * t[1] - else - size = SIZE_MAP[t] - end - if( size > @size ) - @size = size - end - } + @offset = Array.new(types.length, 0) + @size = self.class.size types end end end -- cgit v1.2.3