From 42fe7ceb501b9eef9e7f8349fc23a6c58941b714 Mon Sep 17 00:00:00 2001 From: usa Date: Thu, 16 Nov 2017 12:26:04 +0000 Subject: Old gem file had not been removed * common.mk (update-gems): `old.delete("gems/#{gem}")` always returns nil because when really downloading new gem, the filename is not in `old`. the real intention of this condition might be checking `old` is empty or not. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'common.mk') diff --git a/common.mk b/common.mk index a037328d59..6e231258c4 100644 --- a/common.mk +++ b/common.mk @@ -1134,7 +1134,7 @@ update-gems: PHONY -e 'old = Dir.glob("gems/#{gem}-*.gem")' \ -e 'gem = "#{gem}-#{ver}.gem"' \ -e 'Downloader::RubyGems.download(gem, "gems", nil) and' \ - -e 'old.delete("gems/#{gem}") and' \ + -e '(old.delete("gems/#{gem}"); !old.empty?) and' \ -e 'File.unlink(*old) and' \ -e 'FileUtils.rm_rf(old.map{'"|n|"'n.chomp(".gem")})' \ gems/bundled_gems -- cgit v1.2.3