From 7914a8726eddc84d232f99829d37331aae6f9cdc Mon Sep 17 00:00:00 2001 From: normal Date: Wed, 17 Sep 2014 21:20:58 +0000 Subject: socket (rsock_connect): fix and refactor for blocking * ext/socket/init.c (rsock_connect): refactor for blocking (wait_connectable): clear error before wait [Bug #9356] We no longer use non-blocking sockets to emulate blocking behavior, so eliminate error-prone and confusing platform-dependent code. According to POSIX, connect() only needs to be called once in the face of EINTR, so do not loop on it. Before waiting on connect, drop any pending errors, since rb_wait_for_single_fd may not clear the existing error properly. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47617 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index dc0c1aed39..7c0b93dedd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Thu Sep 18 05:44:05 2014 Eric Wong + + * ext/socket/init.c (rsock_connect): refactor for blocking + (wait_connectable): clear error before wait + [Bug #9356] + Wed Sep 17 23:12:36 2014 NARUSE, Yui * lib/uri/rfc3986_parser.rb: specify a regexp for :OPAQUE; generic.rb -- cgit v1.2.3