From cc52f511b1d942f8542a4d909ce0a1375ea07738 Mon Sep 17 00:00:00 2001 From: nobu Date: Mon, 21 Dec 2015 01:18:48 +0000 Subject: vm_backtrace.c: ignore ifunc frames * vm_backtrace.c (rb_profile_frames): ignore ifunc frames as it did before. [ruby-core:72409] [Bug #11851] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 5 +++++ test/-ext-/debug/test_profile_frames.rb | 17 +++++++++++++++++ vm_backtrace.c | 10 +++++----- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index c0be0ba772..fa271710d2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Mon Dec 21 10:18:46 2015 Kazuki Yamaguchi + + * vm_backtrace.c (rb_profile_frames): ignore ifunc frames as it + did before. [ruby-core:72409] [Bug #11851] + Mon Dec 21 09:33:17 2015 Karol Bucek * ext/openssl/lib/openssl/ssl.rb (OpenSSL::SSL::SSLSocket): fix diff --git a/test/-ext-/debug/test_profile_frames.rb b/test/-ext-/debug/test_profile_frames.rb index 860652c0cd..5ea506046e 100644 --- a/test/-ext-/debug/test_profile_frames.rb +++ b/test/-ext-/debug/test_profile_frames.rb @@ -102,4 +102,21 @@ class TestProfileFrames < Test::Unit::TestCase end } end + + def test_ifunc_frame + bug11851 = '[ruby-core:72409] [Bug #11851]' + assert_ruby_status([], <<~'end;', bug11851) # do + require '-test-/debug' + class A + include Bug::Debug + def x + profile_frames(0, 10) + end + end + def a + [A.new].each(&:x) + end + a + end; + end end diff --git a/vm_backtrace.c b/vm_backtrace.c index 4267b0dd71..bef61d81e0 100644 --- a/vm_backtrace.c +++ b/vm_backtrace.c @@ -1248,25 +1248,25 @@ rb_profile_frames(int start, int limit, VALUE *buff, int *lines) int i; rb_thread_t *th = GET_THREAD(); rb_control_frame_t *cfp = th->cfp, *end_cfp = RUBY_VM_END_CONTROL_FRAME(th); + const rb_callable_method_entry_t *cme; for (i=0; idef->type == VM_METHOD_TYPE_ISEQ) || (cfp->iseq && cfp->pc)) { + if (cfp->iseq && cfp->pc) { if (start > 0) { start--; continue; } /* record frame info */ - if (cme) { + cme = rb_vm_frame_method_entry(cfp); + if (cme && cme->def->type == VM_METHOD_TYPE_ISEQ) { buff[i] = (VALUE)cme; } else { buff[i] = (VALUE)cfp->iseq; } - if (cfp->iseq && lines) lines[i] = calc_lineno(cfp->iseq, cfp->pc); + if (lines) lines[i] = calc_lineno(cfp->iseq, cfp->pc); i++; } -- cgit v1.2.3