From a0ce0b6297852f64f6a05593e1364619da7a831d Mon Sep 17 00:00:00 2001 From: Kazuhiro NISHIYAMA Date: Sun, 22 Sep 2019 10:11:06 +0900 Subject: Add `if: always()` because 2.4.x's `make check` failed on snapshot [ci skip] `check-snapshot-ruby_2_4` uses `make test` instead of `make check`. https://github.com/ruby/actions/blob/95692e54f4263501db1508d51c1fb67c03b4f575/.github/workflows/snapshot.yml#L448-L449 `draft-release` use `make check` to make it simple, and actions is required regardless of success or failure. On the other hand, snapshot success can be ignored, so normally it should not fail. --- .github/workflows/draft-release.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/draft-release.yml b/.github/workflows/draft-release.yml index b76de559d6..cc82e8054f 100644 --- a/.github/workflows/draft-release.yml +++ b/.github/workflows/draft-release.yml @@ -129,8 +129,10 @@ jobs: run: cd ruby-*/ && make $JOBS check TESTOPTS="-q --tty=no" MSPECOPT="-ff" - name: make install run: cd ruby-*/ && sudo make $JOBS install + if: always() # `make check` may fail when 2.4.x - name: ruby -v run: ruby -v + if: always() # `make check` may fail when 2.4.x - uses: k0kubun/action-slack@v2.0.0 with: payload: | -- cgit v1.2.3