From 9f2e41b7e0be219e1db219dbc31f4a0a8c892809 Mon Sep 17 00:00:00 2001 From: knu Date: Mon, 15 Jun 2015 05:37:38 +0000 Subject: * lib/set.rb: Make Set#each and SortedSet#each generate a sized enumerator. [GH-931] by kachick (Kenichi Kamiya) * test/test_set.rb: Import tests from Set into SortedSet. [GH-931] by kachick (Kenichi Kamiya) git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 8 ++++++++ lib/set.rb | 4 ++-- test/test_set.rb | 27 +++++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index c5095c9767..512f3252ae 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +Mon Jun 15 14:33:02 2015 Akinori MUSHA + + * lib/set.rb: Make Set#each and SortedSet#each generate a sized + enumerator. [GH-931] by kachick (Kenichi Kamiya) + + * test/test_set.rb: Import tests from Set into SortedSet. [GH-931] + by kachick (Kenichi Kamiya) + Mon Jun 15 02:26:34 2015 NARUSE, Yui * lib/net/http.rb (Net::HTTP#connect): use connect_nonblock and diff --git a/lib/set.rb b/lib/set.rb index 59d70e82ca..d612fdcb92 100644 --- a/lib/set.rb +++ b/lib/set.rb @@ -284,7 +284,7 @@ class Set # the element as parameter. Returns an enumerator if no block is # given. def each(&block) - block or return enum_for(__method__) + block or return enum_for(__method__) { size } @hash.each_key(&block) self end @@ -663,7 +663,7 @@ class SortedSet < Set end def each(&block) - block or return enum_for(__method__) + block or return enum_for(__method__) { size } to_a.each(&block) self end diff --git a/test/test_set.rb b/test/test_set.rb index e9867dd923..854bcc637b 100644 --- a/test/test_set.rb +++ b/test/test_set.rb @@ -364,6 +364,10 @@ class TC_Set < Test::Unit::TestCase ary.empty? or raise "forgotten elements: #{ary.join(', ')}" } + + assert_equal(6, e.size) + set << 42 + assert_equal(7, e.size) end def test_add @@ -669,6 +673,29 @@ class TC_SortedSet < Test::Unit::TestCase assert_equal(['four', 'one', 'three', 'two'], s.to_a) assert_equal(['four', 'one', 'three', 'two'], a) end + + def test_each + ary = [1,3,5,7,10,20] + set = SortedSet.new(ary) + + ret = set.each { |o| } + assert_same(set, ret) + + e = set.each + assert_instance_of(Enumerator, e) + + assert_nothing_raised { + set.each { |o| + ary.delete(o) or raise "unexpected element: #{o}" + } + + ary.empty? or raise "forgotten elements: #{ary.join(', ')}" + } + + assert_equal(6, e.size) + set << 42 + assert_equal(7, e.size) + end end class TC_Enumerable < Test::Unit::TestCase -- cgit v1.2.3