From 97e37d6805042175805d04a654d423422f670281 Mon Sep 17 00:00:00 2001 From: nobu Date: Fri, 25 Jul 2014 03:21:12 +0000 Subject: compile.c: make the receiver condition cleaner * compile.c (defined_expr): make the condition if the receiver is explicit or implicit cleaner. [fix GH-681] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 5 +++++ compile.c | 15 ++++----------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index e9822eeb59..cd7e885ce0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Fri Jul 25 12:21:11 2014 Santiago Pastorino + + * compile.c (defined_expr): make the condition if the receiver + is explicit or implicit cleaner. [fix GH-681] + Fri Jul 25 03:53:52 2014 Eric Hodel * doc/keywords.rdoc: [DOC] Describe each keyword. diff --git a/compile.c b/compile.c index a77751087b..051b369fc1 100644 --- a/compile.c +++ b/compile.c @@ -2899,17 +2899,10 @@ defined_expr(rb_iseq_t *iseq, LINK_ANCHOR *ret, case NODE_VCALL: case NODE_FCALL: case NODE_ATTRASGN:{ - int self = TRUE; + const int explicit_receiver = + (type == NODE_CALL || + (type == NODE_ATTRASGN && !private_recv_p(node))); - switch (type) { - case NODE_ATTRASGN: - if (private_recv_p(node)) break; - case NODE_CALL: - self = FALSE; - break; - default: - /* through */; - } if (!lfinish[1]) { lfinish[1] = NEW_LABEL(nd_line(node)); } @@ -2917,7 +2910,7 @@ defined_expr(rb_iseq_t *iseq, LINK_ANCHOR *ret, defined_expr(iseq, ret, node->nd_args, lfinish, Qfalse); ADD_INSNL(ret, nd_line(node), branchunless, lfinish[1]); } - if (!self) { + if (explicit_receiver) { defined_expr(iseq, ret, node->nd_recv, lfinish, Qfalse); ADD_INSNL(ret, nd_line(node), branchunless, lfinish[1]); COMPILE(ret, "defined/recv", node->nd_recv); -- cgit v1.2.3