From 8328d8a2b72bc37778a2ca9d8a82c205d08dfa4c Mon Sep 17 00:00:00 2001 From: kou Date: Sun, 11 Aug 2013 09:42:37 +0000 Subject: * lib/rexml/parsers/sax2parser.rb (REXML::Parsers::SAX2Parser#handle_entitydecl): Extract. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42519 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 5 ++++ lib/rexml/parsers/sax2parser.rb | 52 ++++++++++++++++++++++------------------- 2 files changed, 33 insertions(+), 24 deletions(-) diff --git a/ChangeLog b/ChangeLog index 282b3e509f..ecb220b081 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Sun Aug 11 18:42:13 2013 Kouhei Sutou + + * lib/rexml/parsers/sax2parser.rb + (REXML::Parsers::SAX2Parser#handle_entitydecl): Extract. + Sun Aug 11 18:40:25 2013 Kouhei Sutou * lib/rexml/parsers/sax2parser.rb (REXML::Parsers::SAX2Parser#parse): diff --git a/lib/rexml/parsers/sax2parser.rb b/lib/rexml/parsers/sax2parser.rb index 5e0f0fbf95..46ea8faa4d 100644 --- a/lib/rexml/parsers/sax2parser.rb +++ b/lib/rexml/parsers/sax2parser.rb @@ -176,30 +176,7 @@ module REXML } handle( :characters, copy ) when :entitydecl - @entities[ event[1] ] = event[2] if event.size == 3 - parameter_reference_p = false - case event[2] - when "SYSTEM" - if event.size == 5 - if event.last == "%" - parameter_reference_p = true - else - event[4, 0] = "NDATA" - end - end - when "PUBLIC" - if event.size == 6 - if event.last == "%" - parameter_reference_p = true - else - event[5, 0] = "NDATA" - end - end - else - parameter_reference_p = (event.size == 4) - end - event[1, 0] = event.pop if parameter_reference_p - handle( event[0], event[1..-1] ) + handle_entitydecl( event ) when :processing_instruction, :comment, :attlistdecl, :elementdecl, :cdata, :notationdecl, :xmldecl handle( *event ) @@ -220,6 +197,33 @@ module REXML } if listeners end + def handle_entitydecl( event ) + @entities[ event[1] ] = event[2] if event.size == 3 + parameter_reference_p = false + case event[2] + when "SYSTEM" + if event.size == 5 + if event.last == "%" + parameter_reference_p = true + else + event[4, 0] = "NDATA" + end + end + when "PUBLIC" + if event.size == 6 + if event.last == "%" + parameter_reference_p = true + else + event[5, 0] = "NDATA" + end + end + else + parameter_reference_p = (event.size == 4) + end + event[1, 0] = event.pop if parameter_reference_p + handle( event[0], event[1..-1] ) + end + # The following methods are duplicates, but it is faster than using # a helper def get_procs( symbol, name ) -- cgit v1.2.3