From 648ee72d1848ce524c58f336b45c5371e17cb780 Mon Sep 17 00:00:00 2001 From: nagachika Date: Mon, 27 Mar 2017 16:17:42 +0000 Subject: merge revision(s) 57236: [Backport #13089] rational.c: memory leak in gcd * rational.c (rb_gcd_gmp): fix memory leak. patched by KISHIMOTO, Makoto in [ruby-dev:49934]. [Bug #13089] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@58173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- rational.c | 5 +++++ test/ruby/test_rational.rb | 10 ++++++++++ version.h | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/rational.c b/rational.c index 6b248e3483..ca65518c82 100644 --- a/rational.c +++ b/rational.c @@ -286,10 +286,15 @@ rb_gcd_gmp(VALUE x, VALUE y) mpz_gcd(mz, mx, my); + mpz_clear(mx); + mpz_clear(my); + zn = (mpz_sizeinbase(mz, 16) + SIZEOF_BDIGIT*2 - 1) / (SIZEOF_BDIGIT*2); z = rb_big_new(zn, 1); mpz_export(BIGNUM_DIGITS(z), &count, -1, sizeof(BDIGIT), 0, nails, mz); + mpz_clear(mz); + return rb_big_norm(z); } #endif diff --git a/test/ruby/test_rational.rb b/test/ruby/test_rational.rb index ccef384d94..32a50e90fa 100644 --- a/test/ruby/test_rational.rb +++ b/test/ruby/test_rational.rb @@ -870,6 +870,16 @@ class Rational_Test < Test::Unit::TestCase assert_equal(1152921470247108503, 1073741789.lcm(1073741827)) end + def test_gcd_no_memory_leak + assert_no_memory_leak([], "#{<<-"begin;"}", "#{<<-"end;"}", limit: 1.2, rss: true) + x = (1<<121) + 1 + y = (1<<99) + 1 + 1000.times{x.gcd(y)} + begin; + 100.times {1000.times{x.gcd(y)}} + end; + end + def test_supp assert_equal(true, 1.real?) assert_equal(true, 1.1.real?) diff --git a/version.h b/version.h index 50ecb64780..1c84e14839 100644 --- a/version.h +++ b/version.h @@ -1,6 +1,6 @@ #define RUBY_VERSION "2.3.3" #define RUBY_RELEASE_DATE "2017-03-28" -#define RUBY_PATCHLEVEL 282 +#define RUBY_PATCHLEVEL 283 #define RUBY_RELEASE_YEAR 2017 #define RUBY_RELEASE_MONTH 3 -- cgit v1.2.3