From 5bbddba20b25cb2ddb7fbc82c355fb2f25633f73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Thu, 21 May 2020 19:19:50 +0200 Subject: [rubygems/rubygems] Modify `RakeFileUtils.verbose_flag` only when needed https://github.com/rubygems/rubygems/commit/d490309d75 --- test/rubygems/test_gem_package_task.rb | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/test/rubygems/test_gem_package_task.rb b/test/rubygems/test_gem_package_task.rb index 0ce9f08b01..51b2e6c3bb 100644 --- a/test/rubygems/test_gem_package_task.rb +++ b/test/rubygems/test_gem_package_task.rb @@ -5,19 +5,8 @@ require 'rubygems/package_task' class TestGemPackageTask < Gem::TestCase - def setup - super - - @original_rake_fileutils_verbosity = RakeFileUtils.verbose_flag - end - - def teardown - RakeFileUtils.verbose_flag = @original_rake_fileutils_verbosity - - super - end - def test_gem_package + original_rake_fileutils_verbosity = RakeFileUtils.verbose_flag RakeFileUtils.verbose_flag = false gem = Gem::Specification.new do |g| @@ -45,6 +34,8 @@ class TestGemPackageTask < Gem::TestCase assert_path_exists 'pkg/pkgr-1.2.3.gem' end + ensure + RakeFileUtils.verbose_flag = original_rake_fileutils_verbosity end def test_gem_package_prints_to_stdout_by_default @@ -78,8 +69,6 @@ class TestGemPackageTask < Gem::TestCase end def test_gem_package_with_current_platform - RakeFileUtils.verbose_flag = false - gem = Gem::Specification.new do |g| g.name = "pkgr" g.version = "1.2.3" @@ -93,8 +82,6 @@ class TestGemPackageTask < Gem::TestCase end def test_gem_package_with_ruby_platform - RakeFileUtils.verbose_flag = false - gem = Gem::Specification.new do |g| g.name = "pkgr" g.version = "1.2.3" @@ -108,8 +95,6 @@ class TestGemPackageTask < Gem::TestCase end def test_package_dir_path - RakeFileUtils.verbose_flag = false - gem = Gem::Specification.new do |g| g.name = 'nokogiri' g.version = '1.5.0' -- cgit v1.2.3