From 4def2274b2685eab2c2a3bc4cd831faf1382e5e9 Mon Sep 17 00:00:00 2001 From: usa Date: Tue, 9 Jun 2015 07:16:31 +0000 Subject: merge revision(s) 50515: [Backport #11155] * load.c (loaded_feature_path): stop returning false negatives for filenames which are trailing substrings of file extensions. For example, 'b', which a trailing substring of ".rb" should not return false. [Bug #11155][ruby-core:69206] * test/ruby/test_autoload.rb: test for fix git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@50805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 9 +++++++++ load.c | 2 +- test/ruby/test_autoload.rb | 26 ++++++++++++++++++++++++++ version.h | 8 ++++---- 4 files changed, 40 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index eac9953e71..bcd48a7283 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +Tue Jun 9 16:15:31 2015 Aaron Patterson + + * load.c (loaded_feature_path): stop returning false negatives for + filenames which are trailing substrings of file extensions. For + example, 'b', which a trailing substring of ".rb" should not return + false. [Bug #11155][ruby-core:69206] + + * test/ruby/test_autoload.rb: test for fix + Fri May 29 14:03:33 2015 Matt Hoyle * ext/bigdecimal/bigdecimal.c (VpSetPTR): fix a typo, 'expoennt' diff --git a/load.c b/load.c index e5014c165f..fe34b422ee 100644 --- a/load.c +++ b/load.c @@ -319,7 +319,7 @@ loaded_feature_path(const char *name, long vlen, const char *feature, long len, const char *e; if (vlen < len+1) return 0; - if (!strncmp(name+(vlen-len), feature, len)) { + if (strchr(feature, '.') && !strncmp(name+(vlen-len), feature, len)) { plen = vlen - len; } else { diff --git a/test/ruby/test_autoload.rb b/test/ruby/test_autoload.rb index 1931df45c5..f88bcac579 100644 --- a/test/ruby/test_autoload.rb +++ b/test/ruby/test_autoload.rb @@ -56,6 +56,32 @@ p Foo::Bar } end + def test_autoload_with_unqualified_file_name # [ruby-core:69206] + lp = $LOAD_PATH.dup + lf = $LOADED_FEATURES.dup + + Dir.mktmpdir('autoload') { |tmpdir| + $LOAD_PATH << tmpdir + + Dir.chdir(tmpdir) do + eval <<-END + class ::Object + module A + autoload :C, 'b' + end + end + END + + File.open('b.rb', 'w') {|file| file.puts 'module A; class C; end; end'} + assert_kind_of Class, ::A::C + end + } + ensure + $LOAD_PATH.replace lp + $LOADED_FEATURES.replace lf + Object.send(:remove_const, :A) if Object.const_defined?(:A) + end + def test_require_explicit Tempfile.create(['autoload', '.rb']) {|file| file.puts 'class Object; AutoloadTest = 1; end' diff --git a/version.h b/version.h index 8e581f2136..90db321fc8 100644 --- a/version.h +++ b/version.h @@ -1,10 +1,10 @@ #define RUBY_VERSION "2.1.7" -#define RUBY_RELEASE_DATE "2015-05-29" -#define RUBY_PATCHLEVEL 362 +#define RUBY_RELEASE_DATE "2015-06-09" +#define RUBY_PATCHLEVEL 363 #define RUBY_RELEASE_YEAR 2015 -#define RUBY_RELEASE_MONTH 5 -#define RUBY_RELEASE_DAY 29 +#define RUBY_RELEASE_MONTH 6 +#define RUBY_RELEASE_DAY 9 #include "ruby/version.h" -- cgit v1.2.3