From 296150a27ff784cc0fd3d52dabc6e67a3d96d662 Mon Sep 17 00:00:00 2001 From: shyouhei Date: Thu, 17 Jul 2008 12:42:52 +0000 Subject: * lib/net/smtp.rb (Net::SMTP::start): revert to avoid RFC2821 violation. [ruby-dev:35487] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8_7@18118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 5 +++++ lib/net/smtp.rb | 6 +++--- version.h | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 73c2a27f49..1e181add1b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Thu Jul 17 21:42:07 2008 URABE Shyouhei + + * lib/net/smtp.rb (Net::SMTP::start): revert to avoid RFC2821 + violation. [ruby-dev:35487] + Thu Jul 17 21:32:49 2008 Tanaka Akira * string.c (rb_str_format_m): make tmp volatile to avoid possible GC diff --git a/lib/net/smtp.rb b/lib/net/smtp.rb index 5cce6cc50c..57dee9a496 100644 --- a/lib/net/smtp.rb +++ b/lib/net/smtp.rb @@ -437,7 +437,7 @@ module Net # +port+ is the port to connect to; it defaults to port 25. # # +helo+ is the _HELO_ _domain_ provided by the client to the - # server (see overview comments); it defaults to 'localhost'. + # server (see overview comments); it defaults to 'localhost.localdomain'. # # The remaining arguments are used for SMTP authentication, if required # or desired. +user+ is the account name; +secret+ is your password @@ -457,7 +457,7 @@ module Net # * IOError # * TimeoutError # - def SMTP.start(address, port = nil, helo = 'localhost', + def SMTP.start(address, port = nil, helo = 'localhost.localdomain', user = nil, secret = nil, authtype = nil, &block) # :yield: smtp new(address, port).start(helo, user, secret, authtype, &block) @@ -518,7 +518,7 @@ module Net # * IOError # * TimeoutError # - def start(helo = 'localhost', + def start(helo = 'localhost.localdomain', user = nil, secret = nil, authtype = nil) # :yield: smtp if block_given? begin diff --git a/version.h b/version.h index e89a6021cb..d0b8bc9ff6 100644 --- a/version.h +++ b/version.h @@ -2,7 +2,7 @@ #define RUBY_RELEASE_DATE "2008-07-17" #define RUBY_VERSION_CODE 187 #define RUBY_RELEASE_CODE 20080717 -#define RUBY_PATCHLEVEL 62 +#define RUBY_PATCHLEVEL 63 #define RUBY_VERSION_MAJOR 1 #define RUBY_VERSION_MINOR 8 -- cgit v1.2.3