From 227e7ba29cf0a029845136cadee989b6a1bb85ed Mon Sep 17 00:00:00 2001 From: matz Date: Mon, 24 Jul 2006 09:28:15 +0000 Subject: * process.c (rb_f_system): add security check. [ruby-talk:202947] * process.c (rb_f_system): move signal right before fork to avoid signal handler intervention. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@10592 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 7 +++++++ process.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6ad1394dfa..788daa8429 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Mon Jul 24 17:55:55 2006 Yukihiro Matsumoto + + * process.c (rb_f_system): add security check. [ruby-talk:202947] + + * process.c (rb_f_system): move signal right before fork to avoid + signal handler intervention. + Mon Jul 24 15:51:52 2006 Tanaka Akira * ext/readline/readline.c (readline_readline): rl_deprep_term_function diff --git a/process.c b/process.c index 4271c2ff1b..76720977c8 100644 --- a/process.c +++ b/process.c @@ -1494,7 +1494,6 @@ rb_f_system(argc, argv) int i; RETSIGTYPE (*chfunc)(int); - chfunc = signal(SIGCHLD, SIG_DFL); fflush(stdout); fflush(stderr); if (argc == 0) { @@ -1516,6 +1515,8 @@ rb_f_system(argc, argv) for (i = 0; i < argc; i++) { SafeStringValue(argv[i]); } + security(RSTRING(prog ? prog : argv[0])->ptr); + chfunc = signal(SIGCHLD, SIG_DFL); retry: pid = fork(); if (pid == 0) { -- cgit v1.2.3