From 08759d1f0abcd9829becff4178858ffd5dbc6c71 Mon Sep 17 00:00:00 2001 From: shyouhei Date: Wed, 25 Nov 2009 08:45:13 +0000 Subject: merge revision(s) 25485: * io.c (io_fwrite): adjust stdio file position after direct write on BSDish platforms. [ruby-core:26300] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8_7@25918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 5 +++++ io.c | 11 +++++++++++ test/ruby/test_io.rb | 15 +++++++++++++++ version.h | 2 +- 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index c80512d3ee..064b2af1bf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Wed Nov 25 17:42:33 2009 Nobuyoshi Nakada + + * io.c (io_fwrite): adjust stdio file position after direct write on + BSDish platforms. [ruby-core:26300] + Wed Nov 25 17:39:28 2009 Nobuyoshi Nakada * test/ostruct/test_ostruct.rb (test_frozen): added assertions. diff --git a/io.c b/io.c index 1bdb5ec2c9..c3fb3e420d 100644 --- a/io.c +++ b/io.c @@ -37,6 +37,14 @@ # define USE_SETVBUF #endif +#ifndef BSD_STDIO +# if defined(__MACH__) || defined(__DARWIN__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__bsdi__) +# define BSD_STDIO 1 +# else +# define BSD_STDIO 0 +# endif +#endif + #ifdef __QNXNTO__ #include "unix.h" #endif @@ -479,6 +487,9 @@ io_fwrite(str, fptr) TRAP_BEG; r = write(fileno(f), RSTRING(str)->ptr+offset, l); TRAP_END; +#if BSD_STDIO + fseeko(f, lseek(fileno(f), (off_t)0, SEEK_CUR), SEEK_SET); +#endif if (r == n) return len; if (0 <= r) { offset += r; diff --git a/test/ruby/test_io.rb b/test/ruby/test_io.rb index b5e9b8ec06..ce1d4c6668 100644 --- a/test/ruby/test_io.rb +++ b/test/ruby/test_io.rb @@ -45,4 +45,19 @@ class TestIO < Test::Unit::TestCase t.close assert_raise(IOError) {t.binmode} end + + def test_pos + t = make_tempfile + + open(t.path, IO::RDWR|IO::CREAT|IO::TRUNC, 0600) do |f| + f.write "Hello" + assert_equal(5, f.pos) + end + open(t.path, IO::RDWR|IO::CREAT|IO::TRUNC, 0600) do |f| + f.sync = true + f.read + f.write "Hello" + assert_equal(5, f.pos) + end + end end diff --git a/version.h b/version.h index b083535fe7..85084c60ff 100644 --- a/version.h +++ b/version.h @@ -2,7 +2,7 @@ #define RUBY_RELEASE_DATE "2009-11-25" #define RUBY_VERSION_CODE 187 #define RUBY_RELEASE_CODE 20091125 -#define RUBY_PATCHLEVEL 224 +#define RUBY_PATCHLEVEL 225 #define RUBY_VERSION_MAJOR 1 #define RUBY_VERSION_MINOR 8 -- cgit v1.2.3