From a0e80c7cb75d9688a23872ce87ac0354a7b985ad Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Sun, 18 Aug 2019 09:30:33 +0900 Subject: Drop continue-on-error for make check Like macos.yml, we don't need to ignore `make check` failure. --- .github/workflows/ubuntu.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to '.github') diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index b2416ebd32..8c2d3a2fd5 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -45,14 +45,13 @@ jobs: - name: configure run: ./configure -C --disable-install-doc - run: make $JOBS - # TODO: Remove `continue-on-error` once they become stable and also we have a notification for their failure. - name: make check run: make -s ${{ matrix.test_task }} env: TESTOPTS: "$JOBS -q --tty=no" MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies if: matrix.test_task == 'check' - continue-on-error: true + # TODO: Remove `continue-on-error` once they become stable and also we have a notification for their failure. - name: make test-bundler/test-bundled-gems run: make -s ${{ matrix.test_task }} if: matrix.test_task != 'check' -- cgit v1.2.3