From 9874dca3e7c03bcf6969747f06f5c696e518b332 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Wed, 14 Aug 2019 23:00:09 +0900 Subject: Mark bundler / bundled-gems as continue-on-failure because these tests have failed too often and it's false-positive for checking healthiness of the master branch. --- .github/workflows/macos.yml | 11 ++++++++++- .github/workflows/ubuntu.yml | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 2164acd484..bd2a14341e 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -41,10 +41,19 @@ jobs: - name: configure run: ./configure -C --disable-install-doc --with-openssl-dir=$(brew --prefix openssl@1.1) --with-readline-dir=$(brew --prefix readline) - run: make $JOBS - - name: make check/test-bundler/test-bundled-gems + - name: make check run: make -s ${{ matrix.test_task }} env: TESTOPTS: "$JOBS -q --tty=no" MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies + if: matrix.test_task == 'check' + # test-bundler/test-bundled-gems are separated because it randomly fails and ends up cancelling `make check`. + # TODO: Remove `continue-on-error` once they become stable and also we have a notification for their failure. + - name: make test-bundler/test-bundled-gems + run: make -s ${{ matrix.test_task }} + env: + TESTOPTS: "$JOBS -q --tty=no" + continue-on-error: true + if: matrix.test_task != 'check' - name: Leaked Globals run: make -s leaked-globals diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 44dfac56a7..118fe5108e 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -44,7 +44,9 @@ jobs: - name: configure run: ./configure -C --disable-install-doc - run: make $JOBS + # TODO: Remove `continue-on-error` once they become stable and also we have a notification for their failure. - name: make test-bundler/test-bundled-gems run: make -s ${{ matrix.test_task }} + continue-on-error: true - name: Leaked Globals run: make -s leaked-globals -- cgit v1.2.3