path: root/lib/rubygems/core_ext
AgeCommit message (Collapse)Author
2021-07-07Sync RubyGems and Bundler with upstreamHiroshi SHIBATA
Notes: Merged:
2021-03-08Sync latest development version of bundler & rubygemsDavid Rodríguez
Notes: Merged:
2020-12-08Merge prepare version of RubyGems 3.2.0Hiroshi SHIBATA
Notes: Merged:
2020-09-23Revert "Manually merged from"Hiroshi SHIBATA
31a6eaabc165d8a222e176f2c809d90622d88ec2 is obsoleted with
2020-09-23Manually merged from SHIBATA
Enable Style/EmptyLinesAroundClassBody rubocop cop.
2020-07-31[rubygems/rubygems] Fix Kernel#warn override to handle backtrace location ↵Jeremy Evans
with nil path It's very unlikely to hit this case, but it is possible, as Thread::Backtrace::Location#path can return nil if the location is a cfunc with no previous iseq. See location_path in vm_backtrace.c in Ruby. Notes: Merged:
2020-07-31[rubygems/rubygems] Ignore internal frames in RubyGems' Kernel#warnBenoit Daloze
* See * `<internal:` is a common prefix also used by core Ruby files in CRuby. * test_no_kernel_require_in_*warn_with_uplevel already test this. * Unfortunately just skipping `<internal:` in the Ruby implementation is not enough, because RubyGems' #warn would not skip the `<internal:` require (TruffleRuby defines #require in Ruby), and the Ruby implementation's #warn would not skip RubyGems's #require. The #caller_locations(0) look like this: warnee.rb:1:in `<top (required)>' # where #warn is called <internal:core> core/kernel.rb:234:in `gem_original_require' # not skipped by RubyGems' warn, skipped by the Ruby impl rubygems/core_ext/kernel_require.rb:54:in `require' # not skipped by the Ruby impl's warn, what would be shown without this fix warn.rb:1:in `<main>' # what would be correct warn.rb is require "warnee" warnee.rb is puts caller_locations(0), nil warn "oops", uplevel: 1 Notes: Merged:
2020-07-31Enforce no empty lines around class body in rubygemsDavid Rodríguez
To normalize the code style with `bundler`. Notes: Merged:
2020-06-15Use space inside block braces everywhereDavid Rodríguez
To make rubygems code style consistent with bundler. Notes: Merged:
2020-06-05[rubygems/rubygems] Use LoadError#path to figure out the argument passed to ↵Yuki Nishijima
'require' Notes: Merged:
2020-06-05[rubygems/rubygems] Remove direct reference to PRDavid Rodríguez
The code is quite different now, so I think the link might be even confusing. If you want to know more, use git history. Notes: Merged:
2020-06-05[rubygems/rubygems] Fix `$LOADED_FEATURES` cache sometimes not respectedDavid Rodríguez
In the cases where the initial manually `-I` path resolution succeeded, we were passing a full path to the original require effectively skipping the `$LOADED_FEATURES` cache. With this change, we _only_ do the resolution when a matching requirable path is found in a default gem. In that case, we skip activation of the default gem if we detect that the required file will be picked up for a `-I` path. Notes: Merged:
2020-06-05[rubygems/rubygems] Extract a local outside the loopDavid Rodríguez Notes: Merged:
2020-06-05[rubygems/rubygems] Refactor `Gem.load_path_insert_index`David Rodríguez Notes: Merged:
2020-06-05[rubygems/rubygems] Fix performance regression in `require`David Rodríguez
Our check for `-I` paths should not go through all activated gems. Notes: Merged:
2020-05-08[rubygems/rubygems] Simplify nested require exceptionsDavid Rodríguez Notes: Merged:
2020-03-24Sync rubygems with current master (#2889)David Rodríguez
Notes: Merged-By: hsbt <>
2020-02-06Revert "[rubygems/rubygems] Fix require issue with file extension priority"Hiroshi SHIBATA
This reverts commit d767da428c28b7b9fec56b383bb32f6f76c6ad26. It fails with spec/ruby/core/kernel/require_spec.rb:5
2020-02-06[rubygems/rubygems] Fix require issue with file extension priorityDavid Rodríguez
If `require "a"` is run when two folders have been specified in the -I option including a "a.rb" file and a "" file respectively, the ruby spec says that the ".rb" file should always be preferred. However, the logic we added in to make the -I option always beat default gems does not respect this spec, creating a difference from the original ruby-core's require. [the ruby spec says]:
2019-12-13warn should be a global functionNobuyoshi Nakada
2019-12-13Prepare to release RubyGems 3.1.0 final version.Hiroshi SHIBATA
2019-11-13Fix a typoKazuhiro NISHIYAMA
2019-11-12Only enabled mon_owned condition with Ruby 2.5+Hiroshi SHIBATA
2019-11-12check more.Koichi Sasada
2019-11-12Monitor owner state check correctly.Koichi Sasada
Monitor can be owned at the beginning of this method.
2019-11-12Revert "Use untaint for File.symlink in kernel_require.rb"Yusuke Endoh
This reverts commit d9978ce5d397866afae536db2aa708af3b7a4b2f. Untaint was tentatively restored due to test failures. But now, the failed tests have been removed, so we can revert the tentative fix.
2019-11-12Use untaint for File.symlink in kernel_require.rbHiroshi SHIBATA
Partly reverted 7d463e360b9c4718b17378eb52783116a01b884b
2019-11-12release RUBYGEMS_ACTIVATION_MONITOR correctly.Koichi Sasada
`File.symlink? safe_lp` can raise SecurityError and raising an exception can leave RUBYGEMS_ACTIVATION_MONITOR locking. This patch release it correctly.
2019-11-12more messagesKoichi Sasada
2019-11-12check monitor is owning for debugKoichi Sasada
2019-11-11Revert "Try to revert the test failure with Ruby CI"Hiroshi SHIBATA
This reverts commit 8b27c23b5d55bd707a89bb5d95d2bdba9e132c1a.
2019-11-11Try to revert the test failure with Ruby CIHiroshi SHIBATA
2019-11-11Merge RubyGems 3.1.0.pre3Hiroshi SHIBATA
* Fix gem pristine not accounting for user installed gems. Pull request #2914 by Luis Sagastume. * Refactor keyword argument test for Ruby 2.7. Pull request #2947 by SHIBATA Hiroshi. * Fix errors at frozen Gem::Version. Pull request #2949 by Nobuyoshi Nakada. * Remove taint usage on Ruby 2.7+. Pull request #2951 by Jeremy Evans. * Check Manifest.txt is up to date. Pull request #2953 by David Rodríguez. * Clarify symlink conditionals in tests. Pull request #2962 by David Rodríguez. * Update command line parsing to work under ps. Pull request #2966 by David Rodríguez. * Properly test `Gem::Specifications.stub_for`. Pull request #2970 by David Rodríguez. * Fix Gem::LOADED_SPECS_MUTEX handling for recursive locking. Pull request #2985 by MSP-Greg. Notes: Merged:
2019-11-09Remove unneeded exec bits from some filesDavid Rodríguez
I noticed that some files in rubygems were executable, and I could think of no reason why they should be. In general, I think ruby files should never have the executable bit set unless they include a shebang, so I run the following command over the whole repo: ```bash find . -name '*.rb' -type f -executable -exec bash -c 'grep -L "^#!" $1 || chmod -x $1' _ {} \; ``` Notes: Merged:
2019-09-26[rubygems/rubygems] Make sure our modifications to kernel.warn workDavid Rodríguez
And test the fix we're adding.
2019-09-26[rubygems/rubygems] Fix jruby buildDavid Rodríguez
2019-09-26[rubygems/rubygems] Introduce default prerelease requirementDavid Rodríguez
2019-09-25Make rb_scan_args handle keywords more similar to Ruby methods (#2460)Jeremy Evans
Cfuncs that use rb_scan_args with the : entry suffer similar keyword argument separation issues that Ruby methods suffer if the cfuncs accept optional or variable arguments. This makes the following changes to : handling. * Treats as **kw, prompting keyword argument separation warnings if called with a positional hash. * Do not look for an option hash if empty keywords are provided. For backwards compatibility, treat an empty keyword splat as a empty mandatory positional hash argument, but emit a a warning, as this behavior will be removed in Ruby 3. The argument number check needs to be moved lower so it can correctly handle an empty positional argument being added. * If the last argument is nil and it is necessary to treat it as an option hash in order to make sure all arguments are processed, continue to treat the last argument as the option hash. Emit a warning in this case, as this behavior will be removed in Ruby 3. * If splitting the keyword hash into two hashes, issue a warning, as we will not be splitting hashes in Ruby 3. * If the keyword argument is required to fill a mandatory positional argument, continue to do so, but emit a warning as this behavior will be going away in Ruby 3. * If keyword arguments are provided and the last argument is not a hash, that indicates something wrong. This can happen if a cfunc is calling rb_scan_args multiple times, and providing arguments that were not passed to it from Ruby. Callers need to switch to the new rb_scan_args_kw function, which allows passing of whether keywords were provided. This commit fixes all warnings caused by the changes above. It switches some function calls to *_kw versions with appropriate kw_splat flags. If delegating arguments, RB_PASS_CALLED_KEYWORDS is used. If creating new arguments, RB_PASS_KEYWORDS is used if the last argument is a hash to be treated as keywords. In open_key_args in io.c, use rb_scan_args_kw. In this case, the arguments provided come from another C function, not Ruby. The last argument may or may not be a hash, so we can't set keyword argument mode. However, if it is a hash, we don't want to warn when treating it as keywords. In Ruby files, make sure to appropriately use keyword splats or literal keywords when calling Cfuncs that now issue keyword argument separation warnings through rb_scan_args. Also, make sure not to pass nil in place of an option hash. Work around Kernel#warn warnings due to problems in the Rubygems override of the method. There is an open pull request to fix these issues in Rubygems, but part of the Rubygems tests for their override fail on ruby-head due to rb_scan_args not recognizing empty keyword splats, which this commit fixes. Implementation wise, adding rb_scan_args_kw is kind of a pain, because rb_scan_args takes a variable number of arguments. In order to not duplicate all the code, the function internals need to be split into two functions taking a va_list, and to avoid passing in a ton of arguments, a single struct argument is used to handle the variables previously local to the function. Notes: Merged-By: jeremyevans <>
2019-08-17Revert "`Gem.load_path_insert_index always returns non-nil index after Ruby 1.9"Hiroshi SHIBATA
This reverts commit 260ef51a73c067599826c8ab110c53994c1b6226. This broke the stable versions of Ruby like 2.4 and 2.5
2019-08-17Added comments for extended require by RubyGemsHiroshi SHIBATA
2019-08-17`Gem.load_path_insert_index always returns non-nil index after Ruby 1.9Hiroshi SHIBATA
2019-08-17Try to continue on LoadError with gem_original_requireHiroshi SHIBATA
2019-08-17Keep the existance behavior with symlink pathHiroshi SHIBATA
2019-08-17Revert "Revert "[rubygems/rubygems] [Require] Ensure -I beats a default gem""Hiroshi SHIBATA
This reverts commit 75d29db8f965893bb6ab38b9008abc80cdda246e.
2019-08-17Revert "[rubygems/rubygems] [Require] Ensure -I beats a default gem"Hiroshi SHIBATA
This reverts commit 00cd5d74cecb6aa4a184e57e2b8246ef6e45d458.
2019-08-17Fixed Insecure Operation in requireHiroshi SHIBATA
Caused by 00cd5d74ce
2019-08-17[rubygems/rubygems] Don't unregister default specificationsDavid Rodríguez
I think this should be more efficient?
2019-08-17[rubygems/rubygems] Fix jruby issueDavid Rodríguez
2019-08-17[rubygems/rubygems] Fix old rubies compatDavid Rodríguez
2019-08-17[rubygems/rubygems] [Require] Ensure -I beats a default gemSamuel Giddins