diff options
Diffstat (limited to 'range.c')
-rw-r--r-- | range.c | 1213 |
1 files changed, 826 insertions, 387 deletions
@@ -47,11 +47,11 @@ static void range_init(VALUE range, VALUE beg, VALUE end, VALUE exclude_end) { if ((!FIXNUM_P(beg) || !FIXNUM_P(end)) && !NIL_P(beg) && !NIL_P(end)) { - VALUE v; + VALUE v; - v = rb_funcall(beg, id_cmp, 1, end); - if (NIL_P(v)) - rb_raise(rb_eArgError, "bad value for range"); + v = rb_funcall(beg, id_cmp, 1, end); + if (NIL_P(v)) + rb_raise(rb_eArgError, "bad value for range"); } RANGE_SET_EXCL(range, exclude_end); @@ -78,7 +78,7 @@ range_modify(VALUE range) rb_check_frozen(range); /* Ranges are immutable, so that they should be initialized only once. */ if (RANGE_EXCL(range) != Qnil) { - rb_name_err_raise("`initialize' called twice", range, ID2SYM(idInitialize)); + rb_name_err_raise("'initialize' called twice", range, ID2SYM(idInitialize)); } } @@ -140,9 +140,9 @@ recursive_equal(VALUE range, VALUE obj, int recur) { if (recur) return Qtrue; /* Subtle! */ if (!rb_equal(RANGE_BEG(range), RANGE_BEG(obj))) - return Qfalse; + return Qfalse; if (!rb_equal(RANGE_END(range), RANGE_END(obj))) - return Qfalse; + return Qfalse; return RBOOL(EXCL(range) == EXCL(obj)); } @@ -157,7 +157,7 @@ recursive_equal(VALUE range, VALUE obj, int recur) * - +other+ is a range. * - <tt>other.begin == self.begin</tt>. * - <tt>other.end == self.end</tt>. - * - <tt>other.exclude_end? == self.include_end?</tt>. + * - <tt>other.exclude_end? == self.exclude_end?</tt>. * * Otherwise returns +false+. * @@ -183,9 +183,9 @@ static VALUE range_eq(VALUE range, VALUE obj) { if (range == obj) - return Qtrue; + return Qtrue; if (!rb_obj_is_kind_of(obj, rb_cRange)) - return Qfalse; + return Qfalse; return rb_exec_recursive_paired(recursive_equal, range, obj, obj); } @@ -201,7 +201,7 @@ r_less(VALUE a, VALUE b) VALUE r = rb_funcall(a, id_cmp, 1, b); if (NIL_P(r)) - return INT_MAX; + return INT_MAX; return rb_cmpint(r, a, b); } @@ -210,9 +210,9 @@ recursive_eql(VALUE range, VALUE obj, int recur) { if (recur) return Qtrue; /* Subtle! */ if (!rb_eql(RANGE_BEG(range), RANGE_BEG(obj))) - return Qfalse; + return Qfalse; if (!rb_eql(RANGE_END(range), RANGE_END(obj))) - return Qfalse; + return Qfalse; return RBOOL(EXCL(range) == EXCL(obj)); } @@ -224,9 +224,9 @@ recursive_eql(VALUE range, VALUE obj, int recur) * Returns +true+ if and only if: * * - +other+ is a range. - * - <tt>other.begin eql? self.begin</tt>. - * - <tt>other.end eql? self.end</tt>. - * - <tt>other.exclude_end? == self.include_end?</tt>. + * - <tt>other.begin.eql?(self.begin)</tt>. + * - <tt>other.end.eql?(self.end)</tt>. + * - <tt>other.exclude_end? == self.exclude_end?</tt>. * * Otherwise returns +false+. * @@ -251,9 +251,9 @@ static VALUE range_eql(VALUE range, VALUE obj) { if (range == obj) - return Qtrue; + return Qtrue; if (!rb_obj_is_kind_of(obj, rb_cRange)) - return Qfalse; + return Qfalse; return rb_exec_recursive_paired(recursive_eql, range, obj, obj); } @@ -294,34 +294,41 @@ range_each_func(VALUE range, int (*func)(VALUE, VALUE), VALUE arg) VALUE v = b; if (EXCL(range)) { - while (r_less(v, e) < 0) { - if ((*func)(v, arg)) break; - v = rb_funcallv(v, id_succ, 0, 0); - } + while (r_less(v, e) < 0) { + if ((*func)(v, arg)) break; + v = rb_funcallv(v, id_succ, 0, 0); + } } else { - while ((c = r_less(v, e)) <= 0) { - if ((*func)(v, arg)) break; - if (!c) break; - v = rb_funcallv(v, id_succ, 0, 0); - } + while ((c = r_less(v, e)) <= 0) { + if ((*func)(v, arg)) break; + if (!c) break; + v = rb_funcallv(v, id_succ, 0, 0); + } } } -static int -sym_step_i(VALUE i, VALUE arg) +static bool +step_i_iter(VALUE arg) { VALUE *iter = (VALUE *)arg; if (FIXNUM_P(iter[0])) { - iter[0] -= INT2FIX(1) & ~FIXNUM_FLAG; + iter[0] -= INT2FIX(1) & ~FIXNUM_FLAG; } else { - iter[0] = rb_funcall(iter[0], '-', 1, INT2FIX(1)); + iter[0] = rb_funcall(iter[0], '-', 1, INT2FIX(1)); } - if (iter[0] == INT2FIX(0)) { - rb_yield(rb_str_intern(i)); - iter[0] = iter[1]; + if (iter[0] != INT2FIX(0)) return false; + iter[0] = iter[1]; + return true; +} + +static int +sym_step_i(VALUE i, VALUE arg) +{ + if (step_i_iter(arg)) { + rb_yield(rb_str_intern(i)); } return 0; } @@ -329,17 +336,8 @@ sym_step_i(VALUE i, VALUE arg) static int step_i(VALUE i, VALUE arg) { - VALUE *iter = (VALUE *)arg; - - if (FIXNUM_P(iter[0])) { - iter[0] -= INT2FIX(1) & ~FIXNUM_FLAG; - } - else { - iter[0] = rb_funcall(iter[0], '-', 1, INT2FIX(1)); - } - if (iter[0] == INT2FIX(0)) { - rb_yield(i); - iter[0] = iter[1]; + if (step_i_iter(arg)) { + rb_yield(i); } return 0; } @@ -347,7 +345,6 @@ step_i(VALUE i, VALUE arg) static int discrete_object_p(VALUE obj) { - if (rb_obj_is_kind_of(obj, rb_cTime)) return FALSE; /* until Time#succ removed */ return rb_respond_to(obj, id_succ); } @@ -359,7 +356,7 @@ linear_object_p(VALUE obj) switch (BUILTIN_TYPE(obj)) { case T_FLOAT: case T_BIGNUM: - return TRUE; + return TRUE; default: break; } @@ -374,14 +371,14 @@ check_step_domain(VALUE step) VALUE zero = INT2FIX(0); int cmp; if (!rb_obj_is_kind_of(step, rb_cNumeric)) { - step = rb_to_int(step); + step = rb_to_int(step); } cmp = rb_cmpint(rb_funcallv(step, idCmp, 1, &zero), step, zero); if (cmp < 0) { - rb_raise(rb_eArgError, "step can't be negative"); + rb_raise(rb_eArgError, "step can't be negative"); } else if (cmp == 0) { - rb_raise(rb_eArgError, "step can't be 0"); + rb_raise(rb_eArgError, "step can't be 0"); } return step; } @@ -392,11 +389,11 @@ range_step_size(VALUE range, VALUE args, VALUE eobj) VALUE b = RANGE_BEG(range), e = RANGE_END(range); VALUE step = INT2FIX(1); if (args) { - step = check_step_domain(RARRAY_AREF(args, 0)); + step = check_step_domain(RARRAY_AREF(args, 0)); } if (rb_obj_is_kind_of(b, rb_cNumeric) && rb_obj_is_kind_of(e, rb_cNumeric)) { - return ruby_num_interval_step_size(b, e, step, EXCL(range)); + return ruby_num_interval_step_size(b, e, step, EXCL(range)); } return Qnil; } @@ -436,9 +433,8 @@ range_step_size(VALUE range, VALUE args, VALUE eobj) * e.class # => Enumerator::ArithmeticSequence * ('a'..'e').step # => #<Enumerator: ...> * + * Related: Range#%. */ - - static VALUE range_step(int argc, VALUE *argv, VALUE range) { @@ -467,93 +463,112 @@ range_step(int argc, VALUE *argv, VALUE range) } step = check_step_domain(step); + VALUE iter[2] = {INT2FIX(1), step}; if (FIXNUM_P(b) && NIL_P(e) && FIXNUM_P(step)) { - long i = FIX2LONG(b), unit = FIX2LONG(step); - do { - rb_yield(LONG2FIX(i)); - i += unit; /* FIXABLE+FIXABLE never overflow */ - } while (FIXABLE(i)); - b = LONG2NUM(i); + long i = FIX2LONG(b), unit = FIX2LONG(step); + do { + rb_yield(LONG2FIX(i)); + i += unit; /* FIXABLE+FIXABLE never overflow */ + } while (FIXABLE(i)); + b = LONG2NUM(i); - for (;; b = rb_big_plus(b, step)) - rb_yield(b); + for (;; b = rb_big_plus(b, step)) + rb_yield(b); } else if (FIXNUM_P(b) && FIXNUM_P(e) && FIXNUM_P(step)) { /* fixnums are special */ - long end = FIX2LONG(e); - long i, unit = FIX2LONG(step); - - if (!EXCL(range)) - end += 1; - i = FIX2LONG(b); - while (i < end) { - rb_yield(LONG2NUM(i)); - if (i + unit < i) break; - i += unit; - } + long end = FIX2LONG(e); + long i, unit = FIX2LONG(step); + + if (!EXCL(range)) + end += 1; + i = FIX2LONG(b); + while (i < end) { + rb_yield(LONG2NUM(i)); + if (i + unit < i) break; + i += unit; + } } else if (SYMBOL_P(b) && (NIL_P(e) || SYMBOL_P(e))) { /* symbols are special */ - VALUE iter[2]; - iter[0] = INT2FIX(1); - iter[1] = step; - - b = rb_sym2str(b); - if (NIL_P(e)) { - rb_str_upto_endless_each(b, sym_step_i, (VALUE)iter); - } - else { - rb_str_upto_each(b, rb_sym2str(e), EXCL(range), sym_step_i, (VALUE)iter); - } + b = rb_sym2str(b); + if (NIL_P(e)) { + rb_str_upto_endless_each(b, sym_step_i, (VALUE)iter); + } + else { + rb_str_upto_each(b, rb_sym2str(e), EXCL(range), sym_step_i, (VALUE)iter); + } } else if (ruby_float_step(b, e, step, EXCL(range), TRUE)) { - /* done */ + /* done */ } else if (rb_obj_is_kind_of(b, rb_cNumeric) || - !NIL_P(rb_check_to_integer(b, "to_int")) || - !NIL_P(rb_check_to_integer(e, "to_int"))) { - ID op = EXCL(range) ? '<' : idLE; - VALUE v = b; - int i = 0; - - while (NIL_P(e) || RTEST(rb_funcall(v, op, 1, e))) { - rb_yield(v); - i++; - v = rb_funcall(b, '+', 1, rb_funcall(INT2NUM(i), '*', 1, step)); - } + !NIL_P(rb_check_to_integer(b, "to_int")) || + !NIL_P(rb_check_to_integer(e, "to_int"))) { + ID op = EXCL(range) ? '<' : idLE; + VALUE v = b; + int i = 0; + + while (NIL_P(e) || RTEST(rb_funcall(v, op, 1, e))) { + rb_yield(v); + i++; + v = rb_funcall(b, '+', 1, rb_funcall(INT2NUM(i), '*', 1, step)); + } } else { - tmp = rb_check_string_type(b); - - if (!NIL_P(tmp)) { - VALUE iter[2]; - - b = tmp; - iter[0] = INT2FIX(1); - iter[1] = step; - - if (NIL_P(e)) { - rb_str_upto_endless_each(b, step_i, (VALUE)iter); - } - else { - rb_str_upto_each(b, e, EXCL(range), step_i, (VALUE)iter); - } - } - else { - VALUE args[2]; - - if (!discrete_object_p(b)) { - rb_raise(rb_eTypeError, "can't iterate from %s", - rb_obj_classname(b)); - } - args[0] = INT2FIX(1); - args[1] = step; - range_each_func(range, step_i, (VALUE)args); - } + tmp = rb_check_string_type(b); + + if (!NIL_P(tmp)) { + b = tmp; + if (NIL_P(e)) { + rb_str_upto_endless_each(b, step_i, (VALUE)iter); + } + else { + rb_str_upto_each(b, e, EXCL(range), step_i, (VALUE)iter); + } + } + else { + if (!discrete_object_p(b)) { + rb_raise(rb_eTypeError, "can't iterate from %s", + rb_obj_classname(b)); + } + if (!NIL_P(e)) + range_each_func(range, step_i, (VALUE)iter); + else + for (;; b = rb_funcallv(b, id_succ, 0, 0)) + step_i(b, (VALUE)iter); + } } return range; } +/* + * call-seq: + * %(n) {|element| ... } -> self + * %(n) -> enumerator + * + * Iterates over the elements of +self+. + * + * With a block given, calls the block with selected elements of the range; + * returns +self+: + * + * a = [] + * (1..5).%(2) {|element| a.push(element) } # => 1..5 + * a # => [1, 3, 5] + * a = [] + * ('a'..'e').%(2) {|element| a.push(element) } # => "a".."e" + * a # => ["a", "c", "e"] + * + * With no block given, returns an enumerator, + * which will be of class Enumerator::ArithmeticSequence if +self+ is numeric; + * otherwise of class Enumerator: + * + * e = (1..5) % 2 # => ((1..5).%(2)) + * e.class # => Enumerator::ArithmeticSequence + * ('a'..'e') % 2 # => #<Enumerator: ...> + * + * Related: Range#step. + */ static VALUE range_percent_step(VALUE range, VALUE step) { @@ -571,12 +586,12 @@ int64_as_double_to_num(int64_t i) { union int64_double convert; if (i < 0) { - convert.i = -i; - return DBL2NUM(-convert.d); + convert.i = -i; + return DBL2NUM(-convert.d); } else { - convert.i = i; - return DBL2NUM(convert.d); + convert.i = i; + return DBL2NUM(convert.d); } } @@ -592,11 +607,15 @@ double_as_int64(double d) static int is_integer_p(VALUE v) { + if (rb_integer_type_p(v)) { + return true; + } + ID id_integer_p; VALUE is_int; CONST_ID(id_integer_p, "integer?"); is_int = rb_check_funcall(v, id_integer_p, 0, 0); - return RTEST(is_int) && is_int != Qundef; + return RTEST(is_int) && !UNDEF_P(is_int); } static VALUE @@ -607,53 +626,56 @@ bsearch_integer_range(VALUE beg, VALUE end, int excl) #define BSEARCH_CHECK(expr) \ do { \ - VALUE val = (expr); \ - VALUE v = rb_yield(val); \ - if (FIXNUM_P(v)) { \ - if (v == INT2FIX(0)) return val; \ - smaller = (SIGNED_VALUE)v < 0; \ - } \ - else if (v == Qtrue) { \ - satisfied = val; \ - smaller = 1; \ - } \ - else if (v == Qfalse || v == Qnil) { \ - smaller = 0; \ - } \ - else if (rb_obj_is_kind_of(v, rb_cNumeric)) { \ - int cmp = rb_cmpint(rb_funcall(v, id_cmp, 1, INT2FIX(0)), v, INT2FIX(0)); \ - if (!cmp) return val; \ - smaller = cmp < 0; \ - } \ - else { \ - rb_raise(rb_eTypeError, "wrong argument type %"PRIsVALUE \ - " (must be numeric, true, false or nil)", \ - rb_obj_class(v)); \ - } \ + VALUE val = (expr); \ + VALUE v = rb_yield(val); \ + if (FIXNUM_P(v)) { \ + if (v == INT2FIX(0)) return val; \ + smaller = (SIGNED_VALUE)v < 0; \ + } \ + else if (v == Qtrue) { \ + satisfied = val; \ + smaller = 1; \ + } \ + else if (!RTEST(v)) { \ + smaller = 0; \ + } \ + else if (rb_obj_is_kind_of(v, rb_cNumeric)) { \ + int cmp = rb_cmpint(rb_funcall(v, id_cmp, 1, INT2FIX(0)), v, INT2FIX(0)); \ + if (!cmp) return val; \ + smaller = cmp < 0; \ + } \ + else { \ + rb_raise(rb_eTypeError, "wrong argument type %"PRIsVALUE \ + " (must be numeric, true, false or nil)", \ + rb_obj_class(v)); \ + } \ } while (0) VALUE low = rb_to_int(beg); VALUE high = rb_to_int(end); - VALUE mid, org_high; + VALUE mid; ID id_div; CONST_ID(id_div, "div"); - if (excl) high = rb_funcall(high, '-', 1, INT2FIX(1)); - org_high = high; + if (!excl) high = rb_funcall(high, '+', 1, INT2FIX(1)); + low = rb_funcall(low, '-', 1, INT2FIX(1)); - while (rb_cmpint(rb_funcall(low, id_cmp, 1, high), low, high) < 0) { - mid = rb_funcall(rb_funcall(high, '+', 1, low), id_div, 1, INT2FIX(2)); - BSEARCH_CHECK(mid); - if (smaller) { - high = mid; - } - else { - low = rb_funcall(mid, '+', 1, INT2FIX(1)); - } - } - if (rb_equal(low, org_high)) { - BSEARCH_CHECK(low); - if (!smaller) return Qnil; + /* + * This loop must continue while low + 1 < high. + * Instead of checking low + 1 < high, check low < mid, where mid = (low + high) / 2. + * This is to avoid the cost of calculating low + 1 on each iteration. + * Note that this condition replacement is valid because Integer#div always rounds + * towards negative infinity. + */ + while (mid = rb_funcall(rb_funcall(high, '+', 1, low), id_div, 1, INT2FIX(2)), + rb_cmpint(rb_funcall(low, id_cmp, 1, mid), low, mid) < 0) { + BSEARCH_CHECK(mid); + if (smaller) { + high = mid; + } + else { + low = mid; + } } return satisfied; } @@ -681,84 +703,102 @@ range_bsearch(VALUE range) * by the mantissa. This is true with or without implicit bit. * * Finding the average of two ints needs to be careful about - * potential overflow (since float to long can use 64 bits) - * as well as the fact that -1/2 can be 0 or -1 in C89. + * potential overflow (since float to long can use 64 bits). + * + * The half-open interval (low, high] indicates where the target is located. + * The loop continues until low and high are adjacent. + * + * -1/2 can be either 0 or -1 in C89. However, when low and high are not adjacent, + * the rounding direction of mid = (low + high) / 2 does not affect the result of + * the binary search. * * Note that -0.0 is mapped to the same int as 0.0 as we don't want * (-1...0.0).bsearch to yield -0.0. */ -#define BSEARCH(conv) \ +#define BSEARCH(conv, excl) \ do { \ - RETURN_ENUMERATOR(range, 0, 0); \ - if (EXCL(range)) high--; \ - org_high = high; \ - while (low < high) { \ - mid = ((high < 0) == (low < 0)) ? low + ((high - low) / 2) \ - : (low < -high) ? -((-1 - low - high)/2 + 1) : (low + high) / 2; \ - BSEARCH_CHECK(conv(mid)); \ - if (smaller) { \ - high = mid; \ - } \ - else { \ - low = mid + 1; \ - } \ - } \ - if (low == org_high) { \ - BSEARCH_CHECK(conv(low)); \ - if (!smaller) return Qnil; \ - } \ - return satisfied; \ + RETURN_ENUMERATOR(range, 0, 0); \ + if (!(excl)) high++; \ + low--; \ + while (low + 1 < high) { \ + mid = ((high < 0) == (low < 0)) ? low + ((high - low) / 2) \ + : (low + high) / 2; \ + BSEARCH_CHECK(conv(mid)); \ + if (smaller) { \ + high = mid; \ + } \ + else { \ + low = mid; \ + } \ + } \ + return satisfied; \ } while (0) +#define BSEARCH_FIXNUM(beg, end, excl) \ + do { \ + long low = FIX2LONG(beg); \ + long high = FIX2LONG(end); \ + long mid; \ + BSEARCH(INT2FIX, (excl)); \ + } while (0) beg = RANGE_BEG(range); end = RANGE_END(range); if (FIXNUM_P(beg) && FIXNUM_P(end)) { - long low = FIX2LONG(beg); - long high = FIX2LONG(end); - long mid, org_high; - BSEARCH(INT2FIX); + BSEARCH_FIXNUM(beg, end, EXCL(range)); } #if SIZEOF_DOUBLE == 8 && defined(HAVE_INT64_T) else if (RB_FLOAT_TYPE_P(beg) || RB_FLOAT_TYPE_P(end)) { - int64_t low = double_as_int64(NIL_P(beg) ? -HUGE_VAL : RFLOAT_VALUE(rb_Float(beg))); - int64_t high = double_as_int64(NIL_P(end) ? HUGE_VAL : RFLOAT_VALUE(rb_Float(end))); - int64_t mid, org_high; - BSEARCH(int64_as_double_to_num); + int64_t low = double_as_int64(NIL_P(beg) ? -HUGE_VAL : RFLOAT_VALUE(rb_Float(beg))); + int64_t high = double_as_int64(NIL_P(end) ? HUGE_VAL : RFLOAT_VALUE(rb_Float(end))); + int64_t mid; + BSEARCH(int64_as_double_to_num, EXCL(range)); } #endif else if (is_integer_p(beg) && is_integer_p(end)) { - RETURN_ENUMERATOR(range, 0, 0); - return bsearch_integer_range(beg, end, EXCL(range)); + RETURN_ENUMERATOR(range, 0, 0); + return bsearch_integer_range(beg, end, EXCL(range)); } else if (is_integer_p(beg) && NIL_P(end)) { - VALUE diff = LONG2FIX(1); - RETURN_ENUMERATOR(range, 0, 0); - while (1) { - VALUE mid = rb_funcall(beg, '+', 1, diff); - BSEARCH_CHECK(mid); - if (smaller) { - return bsearch_integer_range(beg, mid, 0); - } - diff = rb_funcall(diff, '*', 1, LONG2FIX(2)); - } + VALUE diff = LONG2FIX(1); + RETURN_ENUMERATOR(range, 0, 0); + while (1) { + VALUE mid = rb_funcall(beg, '+', 1, diff); + BSEARCH_CHECK(mid); + if (smaller) { + if (FIXNUM_P(beg) && FIXNUM_P(mid)) { + BSEARCH_FIXNUM(beg, mid, false); + } + else { + return bsearch_integer_range(beg, mid, false); + } + } + diff = rb_funcall(diff, '*', 1, LONG2FIX(2)); + beg = mid; + } } else if (NIL_P(beg) && is_integer_p(end)) { - VALUE diff = LONG2FIX(-1); - RETURN_ENUMERATOR(range, 0, 0); - while (1) { - VALUE mid = rb_funcall(end, '+', 1, diff); - BSEARCH_CHECK(mid); - if (!smaller) { - return bsearch_integer_range(mid, end, 0); - } - diff = rb_funcall(diff, '*', 1, LONG2FIX(2)); - } + VALUE diff = LONG2FIX(-1); + RETURN_ENUMERATOR(range, 0, 0); + while (1) { + VALUE mid = rb_funcall(end, '+', 1, diff); + BSEARCH_CHECK(mid); + if (!smaller) { + if (FIXNUM_P(mid) && FIXNUM_P(end)) { + BSEARCH_FIXNUM(mid, end, false); + } + else { + return bsearch_integer_range(mid, end, false); + } + } + diff = rb_funcall(diff, '*', 1, LONG2FIX(2)); + end = mid; + } } else { - rb_raise(rb_eTypeError, "can't do binary search for %s", rb_obj_classname(beg)); + rb_raise(rb_eTypeError, "can't do binary search for %s", rb_obj_classname(beg)); } return range; } @@ -787,7 +827,12 @@ sym_each_i(VALUE v, VALUE arg) * (1..4).size # => 4 * (1...4).size # => 3 * (1..).size # => Infinity - * ('a'..'z').size #=> nil + * ('a'..'z').size # => nil + * + * If +self+ is not iterable, raises an exception: + * + * (0.5..2.5).size # TypeError + * (..1).size # TypeError * * Related: Range#count. */ @@ -796,16 +841,19 @@ static VALUE range_size(VALUE range) { VALUE b = RANGE_BEG(range), e = RANGE_END(range); - if (rb_obj_is_kind_of(b, rb_cNumeric)) { + + if (RB_INTEGER_TYPE_P(b)) { if (rb_obj_is_kind_of(e, rb_cNumeric)) { - return ruby_num_interval_step_size(b, e, INT2FIX(1), EXCL(range)); + return ruby_num_interval_step_size(b, e, INT2FIX(1), EXCL(range)); } if (NIL_P(e)) { return DBL2NUM(HUGE_VAL); } } - else if (NIL_P(b)) { - return DBL2NUM(HUGE_VAL); + + if (!discrete_object_p(b)) { + rb_raise(rb_eTypeError, "can't iterate from %s", + rb_obj_classname(b)); } return Qnil; @@ -822,14 +870,13 @@ range_size(VALUE range) * (1...4).to_a # => [1, 2, 3] * ('a'..'d').to_a # => ["a", "b", "c", "d"] * - * Range#entries is an alias for Range#to_a. */ static VALUE range_to_a(VALUE range) { if (NIL_P(RANGE_END(range))) { - rb_raise(rb_eRangeError, "cannot convert endless range to an array"); + rb_raise(rb_eRangeError, "cannot convert endless range to an array"); } return rb_call_super(0, 0); } @@ -907,82 +954,220 @@ range_each(VALUE range) return range_each_fixnum_loop(beg, end, range); } else if (RB_INTEGER_TYPE_P(beg) && (NIL_P(end) || RB_INTEGER_TYPE_P(end))) { - if (SPECIAL_CONST_P(end) || RBIGNUM_POSITIVE_P(end)) { /* end >= FIXNUM_MIN */ - if (!FIXNUM_P(beg)) { - if (RBIGNUM_NEGATIVE_P(beg)) { - do { - rb_yield(beg); - } while (!FIXNUM_P(beg = rb_big_plus(beg, INT2FIX(1)))); + if (SPECIAL_CONST_P(end) || RBIGNUM_POSITIVE_P(end)) { /* end >= FIXNUM_MIN */ + if (!FIXNUM_P(beg)) { + if (RBIGNUM_NEGATIVE_P(beg)) { + do { + rb_yield(beg); + } while (!FIXNUM_P(beg = rb_big_plus(beg, INT2FIX(1)))); if (NIL_P(end)) range_each_fixnum_endless(beg); if (FIXNUM_P(end)) return range_each_fixnum_loop(beg, end, range); - } - else { + } + else { if (NIL_P(end)) range_each_bignum_endless(beg); - if (FIXNUM_P(end)) return range; - } - } - if (FIXNUM_P(beg)) { - i = FIX2LONG(beg); - do { - rb_yield(LONG2FIX(i)); - } while (POSFIXABLE(++i)); - beg = LONG2NUM(i); - } - ASSUME(!FIXNUM_P(beg)); - ASSUME(!SPECIAL_CONST_P(end)); - } - if (!FIXNUM_P(beg) && RBIGNUM_SIGN(beg) == RBIGNUM_SIGN(end)) { - if (EXCL(range)) { - while (rb_big_cmp(beg, end) == INT2FIX(-1)) { - rb_yield(beg); - beg = rb_big_plus(beg, INT2FIX(1)); - } - } - else { - VALUE c; - while ((c = rb_big_cmp(beg, end)) != INT2FIX(1)) { - rb_yield(beg); - if (c == INT2FIX(0)) break; - beg = rb_big_plus(beg, INT2FIX(1)); - } - } - } + if (FIXNUM_P(end)) return range; + } + } + if (FIXNUM_P(beg)) { + i = FIX2LONG(beg); + do { + rb_yield(LONG2FIX(i)); + } while (POSFIXABLE(++i)); + beg = LONG2NUM(i); + } + ASSUME(!FIXNUM_P(beg)); + ASSUME(!SPECIAL_CONST_P(end)); + } + if (!FIXNUM_P(beg) && RBIGNUM_SIGN(beg) == RBIGNUM_SIGN(end)) { + if (EXCL(range)) { + while (rb_big_cmp(beg, end) == INT2FIX(-1)) { + rb_yield(beg); + beg = rb_big_plus(beg, INT2FIX(1)); + } + } + else { + VALUE c; + while ((c = rb_big_cmp(beg, end)) != INT2FIX(1)) { + rb_yield(beg); + if (c == INT2FIX(0)) break; + beg = rb_big_plus(beg, INT2FIX(1)); + } + } + } } else if (SYMBOL_P(beg) && (NIL_P(end) || SYMBOL_P(end))) { /* symbols are special */ - beg = rb_sym2str(beg); - if (NIL_P(end)) { - rb_str_upto_endless_each(beg, sym_each_i, 0); - } - else { - rb_str_upto_each(beg, rb_sym2str(end), EXCL(range), sym_each_i, 0); - } + beg = rb_sym2str(beg); + if (NIL_P(end)) { + rb_str_upto_endless_each(beg, sym_each_i, 0); + } + else { + rb_str_upto_each(beg, rb_sym2str(end), EXCL(range), sym_each_i, 0); + } } else { - VALUE tmp = rb_check_string_type(beg); - - if (!NIL_P(tmp)) { - if (!NIL_P(end)) { - rb_str_upto_each(tmp, end, EXCL(range), each_i, 0); - } - else { - rb_str_upto_endless_each(tmp, each_i, 0); - } - } - else { - if (!discrete_object_p(beg)) { - rb_raise(rb_eTypeError, "can't iterate from %s", - rb_obj_classname(beg)); - } - if (!NIL_P(end)) - range_each_func(range, each_i, 0); - else - for (;; beg = rb_funcallv(beg, id_succ, 0, 0)) - rb_yield(beg); - } + VALUE tmp = rb_check_string_type(beg); + + if (!NIL_P(tmp)) { + if (!NIL_P(end)) { + rb_str_upto_each(tmp, end, EXCL(range), each_i, 0); + } + else { + rb_str_upto_endless_each(tmp, each_i, 0); + } + } + else { + if (!discrete_object_p(beg)) { + rb_raise(rb_eTypeError, "can't iterate from %s", + rb_obj_classname(beg)); + } + if (!NIL_P(end)) + range_each_func(range, each_i, 0); + else + for (;; beg = rb_funcallv(beg, id_succ, 0, 0)) + rb_yield(beg); + } } return range; } +RBIMPL_ATTR_NORETURN() +static void +range_reverse_each_bignum_beginless(VALUE end) +{ + RUBY_ASSERT(RBIGNUM_NEGATIVE_P(end)); + + for (;; end = rb_big_minus(end, INT2FIX(1))) { + rb_yield(end); + } + UNREACHABLE; +} + +static void +range_reverse_each_bignum(VALUE beg, VALUE end) +{ + RUBY_ASSERT(RBIGNUM_POSITIVE_P(beg) == RBIGNUM_POSITIVE_P(end)); + + VALUE c; + while ((c = rb_big_cmp(beg, end)) != INT2FIX(1)) { + rb_yield(end); + if (c == INT2FIX(0)) break; + end = rb_big_minus(end, INT2FIX(1)); + } +} + +static void +range_reverse_each_positive_bignum_section(VALUE beg, VALUE end) +{ + RUBY_ASSERT(!NIL_P(end)); + + if (FIXNUM_P(end) || RBIGNUM_NEGATIVE_P(end)) return; + + if (NIL_P(beg) || FIXNUM_P(beg) || RBIGNUM_NEGATIVE_P(beg)) { + beg = LONG2NUM(FIXNUM_MAX + 1); + } + + range_reverse_each_bignum(beg, end); +} + +static void +range_reverse_each_fixnum_section(VALUE beg, VALUE end) +{ + RUBY_ASSERT(!NIL_P(end)); + + if (!FIXNUM_P(beg)) { + if (!NIL_P(beg) && RBIGNUM_POSITIVE_P(beg)) return; + + beg = LONG2FIX(FIXNUM_MIN); + } + + if (!FIXNUM_P(end)) { + if (RBIGNUM_NEGATIVE_P(end)) return; + + end = LONG2FIX(FIXNUM_MAX); + } + + long b = FIX2LONG(beg); + long e = FIX2LONG(end); + for (long i = e; i >= b; --i) { + rb_yield(LONG2FIX(i)); + } +} + +static void +range_reverse_each_negative_bignum_section(VALUE beg, VALUE end) +{ + RUBY_ASSERT(!NIL_P(end)); + + if (FIXNUM_P(end) || RBIGNUM_POSITIVE_P(end)) { + end = LONG2NUM(FIXNUM_MIN - 1); + } + + if (NIL_P(beg)) { + range_reverse_each_bignum_beginless(end); + } + + if (FIXNUM_P(beg) || RBIGNUM_POSITIVE_P(beg)) return; + + range_reverse_each_bignum(beg, end); +} + +/* + * call-seq: + * reverse_each {|element| ... } -> self + * reverse_each -> an_enumerator + * + * With a block given, passes each element of +self+ to the block in reverse order: + * + * a = [] + * (1..4).reverse_each {|element| a.push(element) } # => 1..4 + * a # => [4, 3, 2, 1] + * + * a = [] + * (1...4).reverse_each {|element| a.push(element) } # => 1...4 + * a # => [3, 2, 1] + * + * With no block given, returns an enumerator. + * + */ + +static VALUE +range_reverse_each(VALUE range) +{ + RETURN_SIZED_ENUMERATOR(range, 0, 0, range_enum_size); + + VALUE beg = RANGE_BEG(range); + VALUE end = RANGE_END(range); + int excl = EXCL(range); + + if (NIL_P(end)) { + rb_raise(rb_eTypeError, "can't iterate from %s", + rb_obj_classname(end)); + } + + if (FIXNUM_P(beg) && FIXNUM_P(end)) { + if (excl) { + if (end == LONG2FIX(FIXNUM_MIN)) return range; + + end = rb_int_minus(end, INT2FIX(1)); + } + + range_reverse_each_fixnum_section(beg, end); + } + else if ((NIL_P(beg) || RB_INTEGER_TYPE_P(beg)) && RB_INTEGER_TYPE_P(end)) { + if (excl) { + end = rb_int_minus(end, INT2FIX(1)); + } + range_reverse_each_positive_bignum_section(beg, end); + range_reverse_each_fixnum_section(beg, end); + range_reverse_each_negative_bignum_section(beg, end); + } + else { + return rb_call_super(0, NULL); + } + + return range; +} + /* * call-seq: * self.begin -> object @@ -1030,7 +1215,7 @@ first_i(RB_BLOCK_CALL_FUNC_ARGLIST(i, cbarg)) long n = NUM2LONG(ary[0]); if (n <= 0) { - rb_iter_break(); + rb_iter_break(); } rb_ary_push(ary[1], i); n--; @@ -1087,19 +1272,15 @@ rb_int_range_last(int argc, VALUE *argv, VALUE range) int x; long n; - assert(argc > 0); + RUBY_ASSERT(argc > 0); b = RANGE_BEG(range); e = RANGE_END(range); - assert(RB_INTEGER_TYPE_P(b) && RB_INTEGER_TYPE_P(e)); + RUBY_ASSERT(RB_INTEGER_TYPE_P(b) && RB_INTEGER_TYPE_P(e)); x = EXCL(range); len_1 = rb_int_minus(e, b); - if (FIXNUM_ZERO_P(len_1) || rb_num_negative_p(len_1)) { - return rb_ary_new_capa(0); - } - if (x) { e = rb_int_minus(e, ONE); len = len_1; @@ -1108,6 +1289,10 @@ rb_int_range_last(int argc, VALUE *argv, VALUE range) len = rb_int_plus(len_1, ONE); } + if (FIXNUM_ZERO_P(len) || rb_num_negative_p(len)) { + return rb_ary_new_capa(0); + } + rb_scan_args(argc, argv, "1", &nv); n = NUM2LONG(nv); if (n < 0) { @@ -1271,27 +1456,26 @@ static VALUE range_min(int argc, VALUE *argv, VALUE range) { if (NIL_P(RANGE_BEG(range))) { - rb_raise(rb_eRangeError, "cannot get the minimum of beginless range"); + rb_raise(rb_eRangeError, "cannot get the minimum of beginless range"); } if (rb_block_given_p()) { if (NIL_P(RANGE_END(range))) { rb_raise(rb_eRangeError, "cannot get the minimum of endless range with custom comparison method"); } - return rb_call_super(argc, argv); + return rb_call_super(argc, argv); } else if (argc != 0) { - return range_first(argc, argv, range); + return range_first(argc, argv, range); } else { - struct cmp_opt_data cmp_opt = { 0, 0 }; - VALUE b = RANGE_BEG(range); - VALUE e = RANGE_END(range); - int c = NIL_P(e) ? -1 : OPTIMIZED_CMP(b, e, cmp_opt); + VALUE b = RANGE_BEG(range); + VALUE e = RANGE_END(range); + int c = NIL_P(e) ? -1 : OPTIMIZED_CMP(b, e); - if (c > 0 || (c == 0 && EXCL(range))) - return Qnil; - return b; + if (c > 0 || (c == 0 && EXCL(range))) + return Qnil; + return b; } } @@ -1383,7 +1567,7 @@ range_max(int argc, VALUE *argv, VALUE range) int nm = FIXNUM_P(e) || rb_obj_is_kind_of(e, rb_cNumeric); if (NIL_P(RANGE_END(range))) { - rb_raise(rb_eRangeError, "cannot get the maximum of endless range"); + rb_raise(rb_eRangeError, "cannot get the maximum of endless range"); } VALUE b = RANGE_BEG(range); @@ -1395,8 +1579,7 @@ range_max(int argc, VALUE *argv, VALUE range) return rb_call_super(argc, argv); } else { - struct cmp_opt_data cmp_opt = { 0, 0 }; - int c = NIL_P(b) ? -1 : OPTIMIZED_CMP(b, e, cmp_opt); + int c = NIL_P(b) ? -1 : OPTIMIZED_CMP(b, e); if (c > 0) return Qnil; @@ -1482,22 +1665,22 @@ rb_range_values(VALUE range, VALUE *begp, VALUE *endp, int *exclp) int excl; if (rb_obj_is_kind_of(range, rb_cRange)) { - b = RANGE_BEG(range); - e = RANGE_END(range); - excl = EXCL(range); + b = RANGE_BEG(range); + e = RANGE_END(range); + excl = EXCL(range); } else if (RTEST(rb_obj_is_kind_of(range, rb_cArithSeq))) { return (int)Qfalse; } else { - VALUE x; - b = rb_check_funcall(range, id_beg, 0, 0); - if (b == Qundef) return (int)Qfalse; - e = rb_check_funcall(range, id_end, 0, 0); - if (e == Qundef) return (int)Qfalse; - x = rb_check_funcall(range, rb_intern("exclude_end?"), 0, 0); - if (x == Qundef) return (int)Qfalse; - excl = RTEST(x); + VALUE x; + b = rb_check_funcall(range, id_beg, 0, 0); + if (UNDEF_P(b)) return (int)Qfalse; + e = rb_check_funcall(range, id_end, 0, 0); + if (UNDEF_P(e)) return (int)Qfalse; + x = rb_check_funcall(range, rb_intern("exclude_end?"), 0, 0); + if (UNDEF_P(x)) return (int)Qfalse; + excl = RTEST(x); } *begp = b; *endp = e; @@ -1621,7 +1804,7 @@ inspect_range(VALUE range, VALUE dummy, int recur) VALUE str, str2 = Qundef; if (recur) { - return rb_str_new2(EXCL(range) ? "(... ... ...)" : "(... .. ...)"); + return rb_str_new2(EXCL(range) ? "(... ... ...)" : "(... .. ...)"); } if (!NIL_P(RANGE_BEG(range)) || NIL_P(RANGE_END(range))) { str = rb_str_dup(rb_inspect(RANGE_BEG(range))); @@ -1633,7 +1816,7 @@ inspect_range(VALUE range, VALUE dummy, int recur) if (NIL_P(RANGE_BEG(range)) || !NIL_P(RANGE_END(range))) { str2 = rb_inspect(RANGE_END(range)); } - if (str2 != Qundef) rb_str_append(str, str2); + if (!UNDEF_P(str2)) rb_str_append(str, str2); return str; } @@ -1666,11 +1849,12 @@ range_inspect(VALUE range) return rb_exec_recursive(inspect_range, range, 0); } -static VALUE range_include_internal(VALUE range, VALUE val, int string_use_cover); +static VALUE range_include_internal(VALUE range, VALUE val); +VALUE rb_str_include_range_p(VALUE beg, VALUE end, VALUE val, VALUE exclusive); /* * call-seq: - * rng === object -> true or false + * self === object -> true or false * * Returns +true+ if +object+ is between <tt>self.begin</tt> and <tt>self.end</tt>. * +false+ otherwise: @@ -1710,8 +1894,6 @@ static VALUE range_include_internal(VALUE range, VALUE val, int string_use_cover static VALUE range_eqq(VALUE range, VALUE val) { - VALUE ret = range_include_internal(range, val, 1); - if (ret != Qundef) return ret; return r_cover_p(range, RANGE_BEG(range), RANGE_END(range), val); } @@ -1743,55 +1925,59 @@ range_eqq(VALUE range, VALUE val) * ('a'..'d').cover?('cc') # => true * * Related: Range#cover?. - * - * Range#member? is an alias for Range#include?. */ static VALUE range_include(VALUE range, VALUE val) { - VALUE ret = range_include_internal(range, val, 0); - if (ret != Qundef) return ret; + VALUE ret = range_include_internal(range, val); + if (!UNDEF_P(ret)) return ret; return rb_call_super(1, &val); } +static inline bool +range_integer_edge_p(VALUE beg, VALUE end) +{ + return (!NIL_P(rb_check_to_integer(beg, "to_int")) || + !NIL_P(rb_check_to_integer(end, "to_int"))); +} + +static inline bool +range_string_range_p(VALUE beg, VALUE end) +{ + return RB_TYPE_P(beg, T_STRING) && RB_TYPE_P(end, T_STRING); +} + +static inline VALUE +range_include_fallback(VALUE beg, VALUE end, VALUE val) +{ + if (NIL_P(beg) && NIL_P(end)) { + if (linear_object_p(val)) return Qtrue; + } + + if (NIL_P(beg) || NIL_P(end)) { + rb_raise(rb_eTypeError, "cannot determine inclusion in beginless/endless ranges"); + } + + return Qundef; +} + static VALUE -range_include_internal(VALUE range, VALUE val, int string_use_cover) +range_include_internal(VALUE range, VALUE val) { VALUE beg = RANGE_BEG(range); VALUE end = RANGE_END(range); int nv = FIXNUM_P(beg) || FIXNUM_P(end) || - linear_object_p(beg) || linear_object_p(end); + linear_object_p(beg) || linear_object_p(end); - if (nv || - !NIL_P(rb_check_to_integer(beg, "to_int")) || - !NIL_P(rb_check_to_integer(end, "to_int"))) { - return r_cover_p(range, beg, end, val); + if (nv || range_integer_edge_p(beg, end)) { + return r_cover_p(range, beg, end, val); } - else if (RB_TYPE_P(beg, T_STRING) || RB_TYPE_P(end, T_STRING)) { - if (RB_TYPE_P(beg, T_STRING) && RB_TYPE_P(end, T_STRING)) { - if (string_use_cover) { - return r_cover_p(range, beg, end, val); - } - else { - VALUE rb_str_include_range_p(VALUE beg, VALUE end, VALUE val, VALUE exclusive); - return rb_str_include_range_p(beg, end, val, RANGE_EXCL(range)); - } - } - else if (NIL_P(beg)) { - VALUE r = rb_funcall(val, id_cmp, 1, end); - if (NIL_P(r)) return Qfalse; - if (rb_cmpint(r, val, end) <= 0) return Qtrue; - return Qfalse; - } - else if (NIL_P(end)) { - VALUE r = rb_funcall(beg, id_cmp, 1, val); - if (NIL_P(r)) return Qfalse; - if (rb_cmpint(r, beg, val) <= 0) return Qtrue; - return Qfalse; - } + else if (range_string_range_p(beg, end)) { + return rb_str_include_range_p(beg, end, val, RANGE_EXCL(range)); } - return Qundef; + + return range_include_fallback(beg, end, val); } static int r_cover_range_p(VALUE range, VALUE beg, VALUE end, VALUE val); @@ -1818,7 +2004,7 @@ static int r_cover_range_p(VALUE range, VALUE beg, VALUE end, VALUE val); * r.cover?(0) # => false * r.cover?(5) # => false * r.cover?('foo') # => false - + * * r = ('a'..'d') * r.cover?('a') # => true * r.cover?('d') # => true @@ -1839,7 +2025,7 @@ static int r_cover_range_p(VALUE range, VALUE beg, VALUE end, VALUE val); * r.cover?(0) # => false * r.cover?(4) # => false * r.cover?('foo') # => false - + * * r = ('a'...'d') * r.cover?('a') # => true * r.cover?('c') # => true @@ -1855,7 +2041,7 @@ static int r_cover_range_p(VALUE range, VALUE beg, VALUE end, VALUE val); * r.cover?(0..4) # => false * r.cover?(1..5) # => false * r.cover?('a'..'d') # => false - + * * r = (1...4) * r.cover?(1..3) # => true * r.cover?(1..4) # => false @@ -1876,6 +2062,49 @@ static int r_cover_range_p(VALUE range, VALUE beg, VALUE end, VALUE val); * - An internal call to <tt><=></tt> returns +nil+; * that is, the operands are not comparable. * + * Beginless ranges cover all values of the same type before the end, + * excluding the end for exclusive ranges. Beginless ranges cover + * ranges that end before the end of the beginless range, or at the + * end of the beginless range for inclusive ranges. + * + * (..2).cover?(1) # => true + * (..2).cover?(2) # => true + * (..2).cover?(3) # => false + * (...2).cover?(2) # => false + * (..2).cover?("2") # => false + * (..2).cover?(..2) # => true + * (..2).cover?(...2) # => true + * (..2).cover?(.."2") # => false + * (...2).cover?(..2) # => false + * + * Endless ranges cover all values of the same type after the + * beginning. Endless exclusive ranges do not cover endless + * inclusive ranges. + * + * (2..).cover?(1) # => false + * (2..).cover?(3) # => true + * (2...).cover?(3) # => true + * (2..).cover?(2) # => true + * (2..).cover?("2") # => false + * (2..).cover?(2..) # => true + * (2..).cover?(2...) # => true + * (2..).cover?("2"..) # => false + * (2...).cover?(2..) # => false + * (2...).cover?(3...) # => true + * (2...).cover?(3..) # => false + * (3..).cover?(2..) # => false + * + * Ranges that are both beginless and endless cover all values and + * ranges, and return true for all arguments, with the exception that + * beginless and endless exclusive ranges do not cover endless + * inclusive ranges. + * + * (nil...).cover?(Object.new) # => true + * (nil...).cover?(nil...) # => true + * (nil..).cover?(nil...) # => true + * (nil...).cover?(nil..) # => false + * (nil...).cover?(1..) # => false + * * Related: Range#include?. * */ @@ -1914,7 +2143,16 @@ r_cover_range_p(VALUE range, VALUE beg, VALUE end, VALUE val) if (!NIL_P(val_beg) && !NIL_P(val_end) && r_less(val_beg, val_end) > (EXCL(val) ? -1 : 0)) return FALSE; if (!NIL_P(val_beg) && !r_cover_p(range, beg, end, val_beg)) return FALSE; - cmp_end = r_less(end, val_end); + + if (!NIL_P(val_end) && !NIL_P(end)) { + VALUE r_cmp_end = rb_funcall(end, id_cmp, 1, val_end); + if (NIL_P(r_cmp_end)) return FALSE; + cmp_end = rb_cmpint(r_cmp_end, end, val_end); + } + else { + cmp_end = r_less(end, val_end); + } + if (EXCL(range) == EXCL(val)) { return cmp_end >= 0; @@ -1927,7 +2165,7 @@ r_cover_range_p(VALUE range, VALUE beg, VALUE end, VALUE val) } val_max = rb_rescue2(r_call_max, val, 0, Qnil, rb_eTypeError, (VALUE)0); - if (val_max == Qnil) return FALSE; + if (NIL_P(val_max)) return FALSE; return r_less(end, val_max) >= 0; } @@ -1936,9 +2174,9 @@ static VALUE r_cover_p(VALUE range, VALUE beg, VALUE end, VALUE val) { if (NIL_P(beg) || r_less(beg, val) <= 0) { - int excl = EXCL(range); - if (NIL_P(end) || r_less(val, end) <= -excl) - return Qtrue; + int excl = EXCL(range); + if (NIL_P(end) || r_less(val, end) <= -excl) + return Qtrue; } return Qfalse; } @@ -1968,7 +2206,7 @@ range_loader(VALUE range, VALUE obj) end = rb_ivar_get(obj, id_end); excl = rb_ivar_get(obj, id_excl); if (!NIL_P(excl)) { - range_init(range, beg, end, RBOOL(RTEST(excl))); + range_init(range, beg, end, RBOOL(RTEST(excl))); } return range; } @@ -1983,7 +2221,7 @@ range_alloc(VALUE klass) /* * call-seq: - * count -> integer0 + * count -> integer * count(object) -> integer * count {|element| ... } -> integer * @@ -2025,30 +2263,152 @@ range_count(int argc, VALUE *argv, VALUE range) * Infinity. Just let it loop. */ return rb_call_super(argc, argv); } - else if (NIL_P(RANGE_END(range))) { + + VALUE beg = RANGE_BEG(range), end = RANGE_END(range); + + if (NIL_P(beg) || NIL_P(end)) { /* We are confident that the answer is Infinity. */ return DBL2NUM(HUGE_VAL); } - else if (NIL_P(RANGE_BEG(range))) { - /* We are confident that the answer is Infinity. */ - return DBL2NUM(HUGE_VAL); + + if (is_integer_p(beg)) { + VALUE size = range_size(range); + if (!NIL_P(size)) { + return size; + } } - else { - return rb_call_super(argc, argv); + + return rb_call_super(argc, argv); +} + +static bool +empty_region_p(VALUE beg, VALUE end, int excl) +{ + if (NIL_P(beg)) return false; + if (NIL_P(end)) return false; + int less = r_less(beg, end); + /* empty range */ + if (less > 0) return true; + if (excl && less == 0) return true; + return false; +} + +/* + * call-seq: + * overlap?(range) -> true or false + * + * Returns +true+ if +range+ overlaps with +self+, +false+ otherwise: + * + * (0..2).overlap?(1..3) #=> true + * (0..2).overlap?(3..4) #=> false + * (0..).overlap?(..0) #=> true + * + * With non-range argument, raises TypeError. + * + * (1..3).overlap?(1) # TypeError + * + * Returns +false+ if an internal call to <tt><=></tt> returns +nil+; + * that is, the operands are not comparable. + * + * (1..3).overlap?('a'..'d') # => false + * + * Returns +false+ if +self+ or +range+ is empty. "Empty range" means + * that its begin value is larger than, or equal for an exclusive + * range, its end value. + * + * (4..1).overlap?(2..3) # => false + * (4..1).overlap?(..3) # => false + * (4..1).overlap?(2..) # => false + * (2...2).overlap?(1..2) # => false + * + * (1..4).overlap?(3..2) # => false + * (..4).overlap?(3..2) # => false + * (1..).overlap?(3..2) # => false + * (1..2).overlap?(2...2) # => false + * + * Returns +false+ if the begin value one of +self+ and +range+ is + * larger than, or equal if the other is an exclusive range, the end + * value of the other: + * + * (4..5).overlap?(2..3) # => false + * (4..5).overlap?(2...4) # => false + * + * (1..2).overlap?(3..4) # => false + * (1...3).overlap?(3..4) # => false + * + * Returns +false+ if the end value one of +self+ and +range+ is + * larger than, or equal for an exclusive range, the end value of the + * other: + * + * (4..5).overlap?(2..3) # => false + * (4..5).overlap?(2...4) # => false + * + * (1..2).overlap?(3..4) # => false + * (1...3).overlap?(3..4) # => false + * + * Note that the method wouldn't make any assumptions about the beginless + * range being actually empty, even if its upper bound is the minimum + * possible value of its type, so all this would return +true+: + * + * (...-Float::INFINITY).overlap?(...-Float::INFINITY) # => true + * (..."").overlap?(..."") # => true + * (...[]).overlap?(...[]) # => true + * + * Even if those ranges are effectively empty (no number can be smaller than + * <tt>-Float::INFINITY</tt>), they are still considered overlapping + * with themselves. + * + * Related: Range#cover?. + */ + +static VALUE +range_overlap(VALUE range, VALUE other) +{ + if (!rb_obj_is_kind_of(other, rb_cRange)) { + rb_raise(rb_eTypeError, "wrong argument type %"PRIsVALUE" (expected Range)", + rb_class_name(rb_obj_class(other))); + } + + VALUE self_beg = RANGE_BEG(range); + VALUE self_end = RANGE_END(range); + int self_excl = EXCL(range); + VALUE other_beg = RANGE_BEG(other); + VALUE other_end = RANGE_END(other); + int other_excl = EXCL(other); + + if (empty_region_p(self_beg, other_end, other_excl)) return Qfalse; + if (empty_region_p(other_beg, self_end, self_excl)) return Qfalse; + + if (!NIL_P(self_beg) && !NIL_P(other_beg)) { + VALUE cmp = rb_funcall(self_beg, id_cmp, 1, other_beg); + if (NIL_P(cmp)) return Qfalse; + /* if both begin values are equal, no more comparisons needed */ + if (rb_cmpint(cmp, self_beg, other_beg) == 0) return Qtrue; } + else if (NIL_P(self_beg) && NIL_P(other_beg)) { + VALUE cmp = rb_funcall(self_end, id_cmp, 1, other_end); + return RBOOL(!NIL_P(cmp)); + } + + if (empty_region_p(self_beg, self_end, self_excl)) return Qfalse; + if (empty_region_p(other_beg, other_end, other_excl)) return Qfalse; + + return Qtrue; } /* A \Range object represents a collection of values * that are between given begin and end values. * - * A range may be created using a literal: + * You can create an \Range object explicitly with: + * + * - A {range literal}[rdoc-ref:syntax/literals.rdoc@Range+Literals]: * - * # Ranges that use '..' to include the given end value. - * (1..4).to_a # => [1, 2, 3, 4] - * ('a'..'d').to_a # => ["a", "b", "c", "d"] - * # Ranges that use '...' to exclude the given end value. - * (1...4).to_a # => [1, 2, 3] - * ('a'...'d').to_a # => ["a", "b", "c"] + * # Ranges that use '..' to include the given end value. + * (1..4).to_a # => [1, 2, 3, 4] + * ('a'..'d').to_a # => ["a", "b", "c", "d"] + * # Ranges that use '...' to exclude the given end value. + * (1...4).to_a # => [1, 2, 3] + * ('a'...'d').to_a # => ["a", "b", "c"] * * A range may be created using method Range.new: * @@ -2094,7 +2454,7 @@ range_count(int argc, VALUE *argv, VALUE range) * * Range.new(1, nil) # => 1.. * - * The literal for an endless range may be written with either two dots + * The literal for an endless range may be written with either two dots * or three. * The range has the same elements, either way. * But note that the two are not equal: @@ -2121,6 +2481,15 @@ range_count(int argc, VALUE *argv, VALUE range) * end * a # => [2, 4, 6, 8, 10] * + * A range can be both beginless and endless. For literal beginless, endless + * ranges, at least the beginning or end of the range must be given as an + * explicit nil value. It is recommended to use an explicit nil beginning and + * implicit nil end, since that is what Ruby uses for Range#inspect: + * + * (nil..) # => (nil..) + * (..nil) # => (nil..) + * (nil..nil) # => (nil..) + * * == Ranges and Other Classes * * An object may be put into a range if its class implements @@ -2157,7 +2526,7 @@ range_count(int argc, VALUE *argv, VALUE range) * * A user-defined class that is to be used in a range * must implement instance <tt><=></tt>; - * see {Integer#<=>}[Integer.html#label-method-i-3C-3D-3E]. + * see Integer#<=>. * To make iteration available, it must also implement * instance method +succ+; see Integer#succ. * @@ -2192,6 +2561,74 @@ range_count(int argc, VALUE *argv, VALUE range) * r.include?(Xs.new(5)) #=> true * r.include?(Xs.new(7)) #=> false * + * == What's Here + * + * First, what's elsewhere. \Class \Range: + * + * - Inherits from {class Object}[rdoc-ref:Object@What-27s+Here]. + * - Includes {module Enumerable}[rdoc-ref:Enumerable@What-27s+Here], + * which provides dozens of additional methods. + * + * Here, class \Range provides methods that are useful for: + * + * - {Creating a Range}[rdoc-ref:Range@Methods+for+Creating+a+Range] + * - {Querying}[rdoc-ref:Range@Methods+for+Querying] + * - {Comparing}[rdoc-ref:Range@Methods+for+Comparing] + * - {Iterating}[rdoc-ref:Range@Methods+for+Iterating] + * - {Converting}[rdoc-ref:Range@Methods+for+Converting] + * - {Methods for Working with JSON}[rdoc-ref:Range@Methods+for+Working+with+JSON] + * + * === Methods for Creating a \Range + * + * - ::new: Returns a new range. + * + * === Methods for Querying + * + * - #begin: Returns the begin value given for +self+. + * - #bsearch: Returns an element from +self+ selected by a binary search. + * - #count: Returns a count of elements in +self+. + * - #end: Returns the end value given for +self+. + * - #exclude_end?: Returns whether the end object is excluded. + * - #first: Returns the first elements of +self+. + * - #hash: Returns the integer hash code. + * - #last: Returns the last elements of +self+. + * - #max: Returns the maximum values in +self+. + * - #min: Returns the minimum values in +self+. + * - #minmax: Returns the minimum and maximum values in +self+. + * - #size: Returns the count of elements in +self+. + * + * === Methods for Comparing + * + * - #==: Returns whether a given object is equal to +self+ (uses #==). + * - #===: Returns whether the given object is between the begin and end values. + * - #cover?: Returns whether a given object is within +self+. + * - #eql?: Returns whether a given object is equal to +self+ (uses #eql?). + * - #include? (aliased as #member?): Returns whether a given object + * is an element of +self+. + * + * === Methods for Iterating + * + * - #%: Requires argument +n+; calls the block with each +n+-th element of +self+. + * - #each: Calls the block with each element of +self+. + * - #step: Takes optional argument +n+ (defaults to 1); + * calls the block with each +n+-th element of +self+. + * + * === Methods for Converting + * + * - #inspect: Returns a string representation of +self+ (uses #inspect). + * - #to_a (aliased as #entries): Returns elements of +self+ in an array. + * - #to_s: Returns a string representation of +self+ (uses #to_s). + * + * === Methods for Working with \JSON + * + * - ::json_create: Returns a new \Range object constructed from the given object. + * - #as_json: Returns a 2-element hash representing +self+. + * - #to_json: Returns a \JSON string representing +self+. + * + * To make these methods available: + * + * require 'json/add/range' + * */ void @@ -2216,6 +2653,7 @@ Init_Range(void) rb_define_method(rb_cRange, "each", range_each, 0); rb_define_method(rb_cRange, "step", range_step, -1); rb_define_method(rb_cRange, "%", range_percent_step, 1); + rb_define_method(rb_cRange, "reverse_each", range_reverse_each, 0); rb_define_method(rb_cRange, "bsearch", range_bsearch, 0); rb_define_method(rb_cRange, "begin", range_begin, 0); rb_define_method(rb_cRange, "end", range_end, 0); @@ -2236,4 +2674,5 @@ Init_Range(void) rb_define_method(rb_cRange, "include?", range_include, 1); rb_define_method(rb_cRange, "cover?", range_cover, 1); rb_define_method(rb_cRange, "count", range_count, -1); + rb_define_method(rb_cRange, "overlap?", range_overlap, 1); } |