summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorYusuke Endoh <mame@ruby-lang.org>2019-12-09 12:04:58 +0900
committerYusuke Endoh <mame@ruby-lang.org>2019-12-09 12:04:58 +0900
commit036bc1da6c6c9b0fa9b7f5968d897a9554dd770e (patch)
treeeb321ed8828e90c830ad63af826400b9bd87c6e0 /test
parent0e71fbc18e97007ac9a9b242b800f34057f5f287 (diff)
vm_args.c (rb_warn_check): Use iseq_unique_id instead of its pointer
If iseq is GC'ed, the pointer of iseq may be reused, which may hide a deprecation warning of keyword argument change. http://ci.rvm.jp/results/trunk-test1@phosphorus-docker/2474221 ``` 1) Failure: TestKeywordArguments#test_explicit_super_kwsplat [/tmp/ruby/v2/src/trunk-test1/test/ruby/test_keyword.rb:549]: --- expected +++ actual @@ -1 +1 @@ -/The keyword argument is passed as the last hash parameter.* for `m'/m +"" ``` This change ad-hocly adds iseq_unique_id for each iseq, and use it instead of iseq pointer. This covers the case where caller is GC'ed. Still, the case where callee is GC'ed, is not covered. But anyway, it is very rare that iseq is GC'ed. Even when it occurs, it just hides some warnings. It's no big deal.
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions