path: root/test/pathname
diff options
authorJeremy Evans <>2019-09-20 19:06:22 -0700
committerJeremy Evans <>2019-11-18 01:00:25 +0200
commitc5c05460ac20abcbc0ed686eb4acf06da7a39a79 (patch)
tree991109a68f3b1cd2e256a936701d3b2badd3ddac /test/pathname
parent7b6a8b5b54448235e17ed187d9d73f56893e1b6f (diff)
Warn on access/modify of $SAFE, and remove effects of modifying $SAFE
This removes the security features added by $SAFE = 1, and warns for access or modification of $SAFE from Ruby-level, as well as warning when calling all public C functions related to $SAFE. This modifies some internal functions that took a safe level argument to no longer take the argument. rb_require_safe now warns, rb_require_string has been added as a version that takes a VALUE and does not warn. One public C function that still takes a safe level argument and that this doesn't warn for is rb_eval_cmd. We may want to consider adding an alternative method that does not take a safe level argument, and warn for rb_eval_cmd.
Notes: Merged:
Diffstat (limited to 'test/pathname')
1 files changed, 0 insertions, 10 deletions
diff --git a/test/pathname/test_pathname.rb b/test/pathname/test_pathname.rb
index 39c792d..4d480a5 100644
--- a/test/pathname/test_pathname.rb
+++ b/test/pathname/test_pathname.rb
@@ -1467,16 +1467,6 @@ class TestPathname < Test::Unit::TestCase
- def test_file_join
- assert_equal("foo/bar", File.join("foo"),"bar")))
- lambda {
- $SAFE = 1
- assert_equal("foo/bar", File.join("foo"),"bar").taint))
- }.call
- ensure
- $SAFE = 0
- end
def test_relative_path_from_casefold
assert_separately([], <<-'end;') # do
module File::Constants