summaryrefslogtreecommitdiff
path: root/string.c
diff options
context:
space:
mode:
author卜部昌平 <shyouhei@ruby-lang.org>2020-06-17 16:05:43 +0900
committer卜部昌平 <shyouhei@ruby-lang.org>2020-06-29 11:05:41 +0900
commitd49924ed81af7f5f00841ce7b4aa423a924d3af0 (patch)
tree7004822a3aac93477ff9597119f50be1c1f9d657 /string.c
parentc422fc4bbcb58a16fc84a287baa3cb2d454d7a81 (diff)
rb_str_match: do not goto into a branch
I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/3247
Diffstat (limited to 'string.c')
-rw-r--r--string.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/string.c b/string.c
index 2abb8296b3..8ccfac5a77 100644
--- a/string.c
+++ b/string.c
@@ -3864,15 +3864,13 @@ rb_str_rindex_m(int argc, VALUE *argv, VALUE str)
static VALUE
rb_str_match(VALUE x, VALUE y)
{
- if (SPECIAL_CONST_P(y)) goto generic;
- switch (BUILTIN_TYPE(y)) {
+ switch (OBJ_BUILTIN_TYPE(y)) {
case T_STRING:
rb_raise(rb_eTypeError, "type mismatch: String given");
case T_REGEXP:
return rb_reg_match(y, x);
- generic:
default:
return rb_funcall(y, idEqTilde, 1, x);
}