summaryrefslogtreecommitdiff
path: root/range.c
diff options
context:
space:
mode:
authorJörg W Mittag <github@joergwmittag.de>2021-10-03 15:16:08 +0200
committerGitHub <noreply@github.com>2021-10-03 22:16:08 +0900
commitfb03598666ddbb9f8b35eb4f599e75654ca7ca06 (patch)
tree2203bf0999e1b1b91946a78ac7d7a529be06dba5 /range.c
parent19f9d9cf739e7fc185ef90d5da5b4b12cf902a52 (diff)
Remove unnecessary checks in `Range#each` [Bug #18237]
In commit:7817a438eb1803e7b3358f43bd1f38479badfbdc, the implementation of `Time#succ`, which had been deprecated for 10 years, was finally removed. During that time, there was an explicit `instance_of?` check in source:range.c#L350 with a comment that the check should be removed once `Time#succ` is removed. Since `Time#succ` is now gone, this check should be removed. Note: this should be coordinated with adding a version guard to the corresponding check in ruby/spec as well.
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/4928 Merged-By: nobu <nobu@ruby-lang.org>
Diffstat (limited to 'range.c')
-rw-r--r--range.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/range.c b/range.c
index c0b855002b..6f44e82600 100644
--- a/range.c
+++ b/range.c
@@ -347,7 +347,6 @@ step_i(VALUE i, VALUE arg)
static int
discrete_object_p(VALUE obj)
{
- if (rb_obj_is_kind_of(obj, rb_cTime)) return FALSE; /* until Time#succ removed */
return rb_respond_to(obj, id_succ);
}