summaryrefslogtreecommitdiff
path: root/numeric.c
diff options
context:
space:
mode:
authorKouhei Yanagita <yanagi@shakenbu.org>2022-07-22 12:05:16 +0900
committerYusuke Endoh <mame@ruby-lang.org>2022-08-12 15:57:52 +0900
commit803a07263001e5466bba0f53fcc85784f4b5c686 (patch)
tree75e93f8d4f8aad0c5038f03f0214efd6ae190e52 /numeric.c
parent24e33b84b5adb29d1d2f541acfba65e225b91b55 (diff)
Improve performance of Integer#ceildiv
This patch is suggested by nobu. Benchmark result: ``` require 'benchmark' n = 10 ** 7 Benchmark.bm do |x| x.report("Fixnum/Fixnum") { a, b = 5, 2; n.times { a.ceildiv(b) } } x.report("Bignum/Bignum") { a, b = 10**100, 10**99 - 1; n.times { a.ceildiv(b) } } x.report("Bignum/Fixnum") { a, b = 10**100, 3; n.times { a.ceildiv(b) } } end ``` Original: ``` user system total real Fixnum/Fixnum 3.340009 0.043029 3.383038 ( 3.384022) Bignum/Bignum 8.229500 0.118543 8.348043 ( 8.349574) Bignum/Fixnum 8.328971 0.097842 8.426813 ( 8.426952) ``` Improved: ``` user system total real Fixnum/Fixnum 0.699140 0.000961 0.700101 ( 0.700199) Bignum/Bignum 5.076165 0.083160 5.159325 ( 5.159360) Bignum/Fixnum 5.548684 0.115372 5.664056 ( 5.666735) ```
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/5965
Diffstat (limited to 'numeric.c')
-rw-r--r--numeric.c23
1 files changed, 0 insertions, 23 deletions
diff --git a/numeric.c b/numeric.c
index 9574bfe024..4f927f00fb 100644
--- a/numeric.c
+++ b/numeric.c
@@ -4269,28 +4269,6 @@ rb_int_idiv(VALUE x, VALUE y)
return num_div(x, y);
}
-/*
- * call-seq:
- * ceildiv(other) -> integer
- *
- * Returns the result of division +self+ by +other+. The result is rounded up to the nearest integer.
- *
- * 3.ceildiv(3) # => 1
- * 4.ceildiv(3) # => 2
- *
- * 4.ceildiv(-3) # => -1
- * -4.ceildiv(3) # => -1
- * -4.ceildiv(-3) # => 2
- *
- * 3.ceildiv(1.2) # => 3
- */
-VALUE
-rb_int_ceildiv(VALUE x, VALUE y)
-{
- VALUE tmp = rb_int_idiv(x, num_uminus(y));
- return num_uminus(tmp);
-}
-
static VALUE
fix_mod(VALUE x, VALUE y)
{
@@ -6277,7 +6255,6 @@ Init_Numeric(void)
rb_define_method(rb_cInteger, "remainder", int_remainder, 1);
rb_define_method(rb_cInteger, "divmod", rb_int_divmod, 1);
rb_define_method(rb_cInteger, "fdiv", rb_int_fdiv, 1);
- rb_define_method(rb_cInteger, "ceildiv", rb_int_ceildiv, 1);
rb_define_method(rb_cInteger, "**", rb_int_pow, 1);
rb_define_method(rb_cInteger, "pow", rb_int_powm, -1); /* in bignum.c */