summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarol Bucek <kares@users.noreply.github.com>2020-06-22 23:15:45 +0200
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2020-07-31 21:07:19 +0900
commite7b6e0ff5823c422cd3e508d2b7104a91a2e36f6 (patch)
tree7fa2e7037eeaee1a7fc79225c61fecbbc2fd4b35
parentc3b480b7764e7854b42c212e77a0ffe402dba6cb (diff)
[rubygems/rubygems] remove explicit require(s) for auto-loaded constant(s)
the Gem module's auto-loads will handle loading these as needed, this started as a redundancy found in *rubygems.rb* which had: `autoload :Specification, 'rubygems/specification'` as well as `require 'rubygems/specification'` https://github.com/rubygems/rubygems/commit/43ceae7ac0
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/3379
-rw-r--r--lib/rubygems.rb2
-rw-r--r--lib/rubygems/dependency.rb3
-rw-r--r--lib/rubygems/gem_runner.rb1
-rw-r--r--lib/rubygems/name_tuple.rb2
-rw-r--r--lib/rubygems/package.rb1
-rw-r--r--lib/rubygems/requirement.rb1
-rw-r--r--lib/rubygems/specification.rb3
7 files changed, 0 insertions, 13 deletions
diff --git a/lib/rubygems.rb b/lib/rubygems.rb
index 68b50611da..75122ed088 100644
--- a/lib/rubygems.rb
+++ b/lib/rubygems.rb
@@ -1333,8 +1333,6 @@ An Array (#{env.inspect}) was passed in from #{caller[3]}
autoload :Specification, File.expand_path('rubygems/specification', __dir__)
autoload :Util, File.expand_path('rubygems/util', __dir__)
autoload :Version, File.expand_path('rubygems/version', __dir__)
-
- require "rubygems/specification"
end
require 'rubygems/exceptions'
diff --git a/lib/rubygems/dependency.rb b/lib/rubygems/dependency.rb
index 461c828d5c..8634d71a72 100644
--- a/lib/rubygems/dependency.rb
+++ b/lib/rubygems/dependency.rb
@@ -2,9 +2,6 @@
##
# The Dependency class holds a Gem name and a Gem::Requirement.
-require "rubygems/bundler_version_finder"
-require "rubygems/requirement"
-
class Gem::Dependency
##
# Valid dependency types.
diff --git a/lib/rubygems/gem_runner.rb b/lib/rubygems/gem_runner.rb
index 48b8cdd13f..a36674503e 100644
--- a/lib/rubygems/gem_runner.rb
+++ b/lib/rubygems/gem_runner.rb
@@ -7,7 +7,6 @@
require 'rubygems'
require 'rubygems/command_manager'
-require 'rubygems/config_file'
require 'rubygems/deprecate'
##
diff --git a/lib/rubygems/name_tuple.rb b/lib/rubygems/name_tuple.rb
index a3fbe950a5..cb5604e8dd 100644
--- a/lib/rubygems/name_tuple.rb
+++ b/lib/rubygems/name_tuple.rb
@@ -4,8 +4,6 @@
# Represents a gem of name +name+ at +version+ of +platform+. These
# wrap the data returned from the indexes.
-require 'rubygems/platform'
-
class Gem::NameTuple
def initialize(name, version, platform="ruby")
@name = name
diff --git a/lib/rubygems/package.rb b/lib/rubygems/package.rb
index 46485f8c81..426d33cdcf 100644
--- a/lib/rubygems/package.rb
+++ b/lib/rubygems/package.rb
@@ -43,7 +43,6 @@
require "rubygems"
require 'rubygems/security'
-require 'rubygems/specification'
require 'rubygems/user_interaction'
require 'zlib'
diff --git a/lib/rubygems/requirement.rb b/lib/rubygems/requirement.rb
index c8c96646e3..65bc83777e 100644
--- a/lib/rubygems/requirement.rb
+++ b/lib/rubygems/requirement.rb
@@ -1,5 +1,4 @@
# frozen_string_literal: true
-require "rubygems/version"
require "rubygems/deprecate"
##
diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb
index 138e5cbae0..ddcd0aa327 100644
--- a/lib/rubygems/specification.rb
+++ b/lib/rubygems/specification.rb
@@ -6,9 +6,6 @@
# See LICENSE.txt for permissions.
#++
-require 'rubygems/version'
-require 'rubygems/requirement'
-require 'rubygems/platform'
require 'rubygems/deprecate'
require 'rubygems/basic_specification'
require 'rubygems/stub_specification'