diff options
| author | Takashi Kokubun <takashikkbn@gmail.com> | 2019-08-18 09:30:33 +0900 |
|---|---|---|
| committer | Takashi Kokubun <takashikkbn@gmail.com> | 2019-08-18 09:30:36 +0900 |
| commit | a0e80c7cb75d9688a23872ce87ac0354a7b985ad (patch) | |
| tree | 874f28e3f15a83fd480ee5b9ed83ddda255716a5 | |
| parent | 50623f3df0c1c82d6995053000285c208835efe8 (diff) | |
Drop continue-on-error for make check
Like macos.yml, we don't need to ignore `make check` failure.
| -rw-r--r-- | .github/workflows/ubuntu.yml | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index b2416ebd32..8c2d3a2fd5 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -45,14 +45,13 @@ jobs: - name: configure run: ./configure -C --disable-install-doc - run: make $JOBS - # TODO: Remove `continue-on-error` once they become stable and also we have a notification for their failure. - name: make check run: make -s ${{ matrix.test_task }} env: TESTOPTS: "$JOBS -q --tty=no" MSPECOPT: "-ff" # not using `-j` because sometimes `mspec -j` silently dies if: matrix.test_task == 'check' - continue-on-error: true + # TODO: Remove `continue-on-error` once they become stable and also we have a notification for their failure. - name: make test-bundler/test-bundled-gems run: make -s ${{ matrix.test_task }} if: matrix.test_task != 'check' |