summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNAKAMURA Usaku <usa@ruby-lang.org>2023-03-30 20:08:27 +0900
committerNAKAMURA Usaku <usa@ruby-lang.org>2023-03-30 20:08:27 +0900
commit153bdddfc2461ba0731e1d03982fee41d5e2b2aa (patch)
tree0a87005531a45b517eedd6e133179623d0daef4f
parent6439ebc47669b6e8b4409e4073a4348939994b7b (diff)
Limit header length
-rw-r--r--lib/net/http/header.rb8
-rw-r--r--version.h2
2 files changed, 9 insertions, 1 deletions
diff --git a/lib/net/http/header.rb b/lib/net/http/header.rb
index 8641be4eae..e04c6056c1 100644
--- a/lib/net/http/header.rb
+++ b/lib/net/http/header.rb
@@ -9,6 +9,8 @@
# convenient formats.
#
module Net::HTTPHeader
+ MAX_KEY_LENGTH = 1024
+ MAX_FIELD_LENGTH = 65536
def initialize_http_header(initheader)
@header = {}
@@ -19,6 +21,12 @@ module Net::HTTPHeader
warn "net/http: nil HTTP header: #{key}", uplevel: 3 if $VERBOSE
else
value = value.strip # raise error for invalid byte sequences
+ if key.bytesize > MAX_KEY_LENGTH
+ raise ArgumentError, "too long (#{key.bytesize} bytes) header: #{key[0, 30].inspect}..."
+ end
+ if value.bytesize > MAX_FIELD_LENGTH
+ raise ArgumentError, "header #{key} has too long field vallue: #{value.bytesize}"
+ end
if value.count("\r\n") > 0
raise ArgumentError, "header #{key} has field value #{value.inspect}, this cannot include CR/LF"
end
diff --git a/version.h b/version.h
index f1d5e76fcf..7844875966 100644
--- a/version.h
+++ b/version.h
@@ -2,7 +2,7 @@
# define RUBY_VERSION_MINOR RUBY_API_VERSION_MINOR
#define RUBY_VERSION_TEENY 8
#define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR
-#define RUBY_PATCHLEVEL 223
+#define RUBY_PATCHLEVEL 224
#define RUBY_RELEASE_YEAR 2023
#define RUBY_RELEASE_MONTH 3