diff options
| author | Alan Wu <XrXr@users.noreply.github.com> | 2025-09-29 21:23:10 -0400 |
|---|---|---|
| committer | Alan Wu <XrXr@users.noreply.github.com> | 2025-09-30 14:08:49 -0400 |
| commit | 14fce2746acc4ff5963d8c296af8b952746e1241 (patch) | |
| tree | 8bf4d5f37f66a08139cedda280cbf0646d03e373 | |
| parent | 83f1082e638e6f9161c4ddd0acad7a658ce4648b (diff) | |
CI: Fail the dump crash log step for visual reminder
I forgot that this step existed and thought crash reporting wasn't
working when they were simply moved to a different step. Failing these
should give a nice visual hint.
| -rw-r--r-- | .github/workflows/yjit-macos.yml | 7 | ||||
| -rw-r--r-- | .github/workflows/yjit-ubuntu.yml | 4 | ||||
| -rw-r--r-- | .github/workflows/zjit-macos.yml | 4 | ||||
| -rw-r--r-- | .github/workflows/zjit-ubuntu.yml | 4 |
4 files changed, 14 insertions, 5 deletions
diff --git a/.github/workflows/yjit-macos.yml b/.github/workflows/yjit-macos.yml index fc538fe51b..6299500ab3 100644 --- a/.github/workflows/yjit-macos.yml +++ b/.github/workflows/yjit-macos.yml @@ -169,9 +169,12 @@ jobs: if: ${{ matrix.test_task == 'check' && matrix.skipped_tests }} continue-on-error: ${{ matrix.continue-on-skipped_tests || false }} - - if: ${{ failure() }} + - name: Dump crash logs + if: ${{ failure() }} continue-on-error: true - run: tail --verbose --lines=+1 rb_crash_*.txt + run: | + tail --verbose --lines=+1 rb_crash_*.txt + exit 1 - uses: ./.github/actions/slack with: diff --git a/.github/workflows/yjit-ubuntu.yml b/.github/workflows/yjit-ubuntu.yml index e086582e24..bf12f80c0e 100644 --- a/.github/workflows/yjit-ubuntu.yml +++ b/.github/workflows/yjit-ubuntu.yml @@ -214,7 +214,9 @@ jobs: - name: Dump crash logs if: ${{ failure() }} continue-on-error: true - run: tail --verbose --lines=+1 rb_crash_*.txt + run: | + tail --verbose --lines=+1 rb_crash_*.txt + exit 1 - uses: ./.github/actions/slack with: diff --git a/.github/workflows/zjit-macos.yml b/.github/workflows/zjit-macos.yml index bc4fef7ce2..a638a3b1b3 100644 --- a/.github/workflows/zjit-macos.yml +++ b/.github/workflows/zjit-macos.yml @@ -136,7 +136,9 @@ jobs: - name: Dump crash logs if: ${{ failure() }} continue-on-error: true - run: tail --verbose --lines=+1 rb_crash_*.txt + run: | + tail --verbose --lines=+1 rb_crash_*.txt + exit 1 - uses: ./.github/actions/slack with: diff --git a/.github/workflows/zjit-ubuntu.yml b/.github/workflows/zjit-ubuntu.yml index 813f88c53b..99d5dbfded 100644 --- a/.github/workflows/zjit-ubuntu.yml +++ b/.github/workflows/zjit-ubuntu.yml @@ -178,7 +178,9 @@ jobs: - name: Dump crash logs if: ${{ failure() }} continue-on-error: true - run: tail --verbose --lines=+1 rb_crash_*.txt + run: | + tail --verbose --lines=+1 rb_crash_*.txt + exit 1 - uses: ./.github/actions/slack with: |