summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Wu <XrXr@users.noreply.github.com>2020-10-15 14:51:30 -0400
committerAlan Wu <XrXr@users.noreply.github.com>2020-10-16 10:24:12 -0400
commit0d17cdd0ac3ae0f3f3608e5430b68467a6a13cc7 (patch)
tree45277b153440a39331c7853b5933b9c95f7fc007
parentde5e8d0e3bc3cc39487ffc9d9c15642b6881cd54 (diff)
Abort on system stack overflow during GC
Buggy native extensions could have mark functions that cause stack overflow. When a stack overflow happens during GC, Ruby used to recover by raising an exception, which runs the interpreter. It's not safe to run the interpreter during GC since the GC is in an inconsistent state. This could cause object allocation during GC, for example. Instead of running the interpreter and potentially causing a crash down the line, fail fast and abort.
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/3661
-rw-r--r--vm_insnhelper.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/vm_insnhelper.c b/vm_insnhelper.c
index 275e5f7394..9eedc10172 100644
--- a/vm_insnhelper.c
+++ b/vm_insnhelper.c
@@ -83,7 +83,10 @@ NORETURN(MJIT_STATIC void rb_ec_stack_overflow(rb_execution_context_t *ec, int c
MJIT_STATIC void
rb_ec_stack_overflow(rb_execution_context_t *ec, int crit)
{
- if (crit || rb_during_gc()) {
+ if (rb_during_gc()) {
+ rb_bug("system stack overflow during GC. Faulty native extension?");
+ }
+ if (crit) {
ec->raised_flag = RAISED_STACKOVERFLOW;
ec->errinfo = rb_ec_vm_ptr(ec)->special_exceptions[ruby_error_stackfatal];
EC_JUMP_TAG(ec, TAG_RAISE);