summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicholas Lee <nicholas.lee@appfolio.com>2021-11-08 15:52:49 -0800
committergit <svn-admin@ruby-lang.org>2021-11-09 10:56:17 +0900
commitd7432fdee585257686f381a5cf04ea53847bd6b8 (patch)
treedc3e23e9c0466bfa54bd7943b073ffd153ffb995
parente014c9d607741180360d72e506885ab23dd032d5 (diff)
[rubygems/rubygems] Use `shellsplit` instead of array of strings
Previously, the command string to be used for the shell command was first generated and then split using shellsplit. This change reverts the current behavior as it breaks if the value of remote contains a space. https://github.com/rubygems/rubygems/commit/6649ee10b0
-rw-r--r--lib/bundler/gem_helper.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/bundler/gem_helper.rb b/lib/bundler/gem_helper.rb
index 60b9e57887..034f2e5960 100644
--- a/lib/bundler/gem_helper.rb
+++ b/lib/bundler/gem_helper.rb
@@ -129,8 +129,8 @@ module Bundler
def git_push(remote = nil)
remote ||= default_remote
- sh(%W[git push #{remote} refs/heads/#{current_branch}])
- sh(%W[git push #{remote} refs/tags/#{version_tag}])
+ sh("git push #{remote} refs/heads/#{current_branch}".shellsplit)
+ sh("git push #{remote} refs/tags/#{version_tag}".shellsplit)
Bundler.ui.confirm "Pushed git commits and release tag."
end