summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-01-26 07:59:54 +0000
committernaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-01-26 07:59:54 +0000
commiteb1d5ab5a0309e117ea2cb05915131393adc893d (patch)
treecdce213710d853dd34449fe288cba2628e941106
parent66be165f30cb6a7d52634ce817013e510094bb1e (diff)
merge revision(s) 66658: [Backport #15489]
vm_args.c: search symbol proc in super classes * vm_args.c (refine_sym_proc_call): traverse ancestors to search inherited methods for symbol proc. [ruby-dev:50741] [Bug #15489] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@66925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--test/ruby/test_symbol.rb6
-rw-r--r--version.h2
-rw-r--r--vm_args.c10
3 files changed, 15 insertions, 3 deletions
diff --git a/test/ruby/test_symbol.rb b/test/ruby/test_symbol.rb
index 6438ec8771..13d7cc9d57 100644
--- a/test/ruby/test_symbol.rb
+++ b/test/ruby/test_symbol.rb
@@ -191,6 +191,12 @@ class TestSymbol < Test::Unit::TestCase
assert_equal(:hogehoge, _test_to_proc_arg_with_refinements_call(&:hoge))
end
+ def test_to_proc_arg_with_refinements_undefined
+ assert_raise(NoMethodError) do
+ _test_to_proc_arg_with_refinements_call(&:foo)
+ end
+ end
+
private def return_from_proc
Proc.new { return 1 }.tap(&:call)
end
diff --git a/version.h b/version.h
index d92d1c9146..709ca85259 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.6.1"
#define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR
-#define RUBY_PATCHLEVEL 27
+#define RUBY_PATCHLEVEL 28
#define RUBY_RELEASE_YEAR 2019
#define RUBY_RELEASE_MONTH 1
diff --git a/vm_args.c b/vm_args.c
index bea38078ec..299ed16aa8 100644
--- a/vm_args.c
+++ b/vm_args.c
@@ -853,6 +853,7 @@ refine_sym_proc_call(RB_BLOCK_CALL_FUNC_ARGLIST(yielded_arg, callback_arg))
rb_execution_context_t *ec;
const VALUE symbol = RARRAY_AREF(callback_arg, 0);
const VALUE refinements = RARRAY_AREF(callback_arg, 1);
+ VALUE klass;
if (argc-- < 1) {
rb_raise(rb_eArgError, "no receiver given");
@@ -860,8 +861,13 @@ refine_sym_proc_call(RB_BLOCK_CALL_FUNC_ARGLIST(yielded_arg, callback_arg))
obj = *argv++;
mid = SYM2ID(symbol);
- me = rb_callable_method_entry(CLASS_OF(obj), mid);
- me = rb_resolve_refined_method_callable(refinements, me);
+ for (klass = CLASS_OF(obj); klass; klass = RCLASS_SUPER(klass)) {
+ me = rb_callable_method_entry(klass, mid);
+ if (me) {
+ me = rb_resolve_refined_method_callable(refinements, me);
+ if (me) break;
+ }
+ }
ec = GET_EC();
if (!NIL_P(blockarg)) {