summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-01-20 04:47:51 +0000
committernagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-01-20 04:47:51 +0000
commitd6ea20ff492df58afcc5a7d83898b1a08bb25556 (patch)
tree95b2b004b0094d4b777bd93885972dfc8a6802db
parent11a64cea0a4c5e72611c40fc92fe9ac0889cd662 (diff)
merge revision(s) 66242: [Backport #15387]
io.c (io_write_nonblock): add RB_GC_GUARD, io_fflush may switch threads Since io_fflush may block on mutex or rb_io_wait_readable and switch threads, we need to ensure the `str' VALUE returned by `rb_obj_as_string` is visible to GC. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@66876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--io.c1
-rw-r--r--version.h6
2 files changed, 4 insertions, 3 deletions
diff --git a/io.c b/io.c
index f14080e21e..94facda8e7 100644
--- a/io.c
+++ b/io.c
@@ -2935,6 +2935,7 @@ io_write_nonblock(VALUE io, VALUE str, VALUE ex)
rb_io_set_nonblock(fptr);
n = write(fptr->fd, RSTRING_PTR(str), RSTRING_LEN(str));
+ RB_GC_GUARD(str);
if (n == -1) {
int e = errno;
diff --git a/version.h b/version.h
index 4bfecb3671..b0a0ccb9b9 100644
--- a/version.h
+++ b/version.h
@@ -1,10 +1,10 @@
#define RUBY_VERSION "2.5.4"
-#define RUBY_RELEASE_DATE "2019-01-17"
-#define RUBY_PATCHLEVEL 131
+#define RUBY_RELEASE_DATE "2019-01-20"
+#define RUBY_PATCHLEVEL 132
#define RUBY_RELEASE_YEAR 2019
#define RUBY_RELEASE_MONTH 1
-#define RUBY_RELEASE_DAY 17
+#define RUBY_RELEASE_DAY 20
#include "ruby/version.h"