summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2015-01-14 07:49:35 +0000
committerusa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2015-01-14 07:49:35 +0000
commit568a5d520b0917e8cfe62c871de1ea6dd4939e2f (patch)
tree6a57dc0b3df6da55af0ddf8cceec21626b8e4bfd
parentf9d88c6059f8b3e512401790ad82574e12c8ccb1 (diff)
merge revision(s) 49071-49073,49078: [Backport #10550]
* lib/resolv.rb (Resolv::DNS::Name#==): DNS is case-insensitive, so the comparison should be case-insensitive as well. [ruby-core:66498] [Bug #10550] * lib/resolv.rb (Resolv::DNS::Name): names with different dots should be different. * lib/resolv.rb (Resolv::DNS::Name#==): Compare an array of Label:Str objects. Label#Str#== is case-insensitive. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@49252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog16
-rw-r--r--lib/resolv.rb3
-rw-r--r--test/resolv/test_dns.rb13
-rw-r--r--version.h2
4 files changed, 32 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 65b79b7a23..543c1f1a27 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
+Wed Jan 14 16:48:15 2015 Tanaka Akira <akr@fsij.org>
+
+ * lib/resolv.rb (Resolv::DNS::Name#==): Compare an array of Label:Str
+ objects. Label#Str#== is case-insensitive.
+
+Wed Jan 14 16:48:15 2015 Ben Miller <bmiller@rackspace.com>
+
+ * lib/resolv.rb (Resolv::DNS::Name#==): DNS is case-insensitive, so the
+ comparison should be case-insensitive as well.
+ [ruby-core:66498] [Bug #10550]
+
+Wed Jan 14 16:48:15 2015 Nobuyoshi Nakada <nobu@ruby-lang.org>
+
+ * lib/resolv.rb (Resolv::DNS::Name): names with different dots
+ should be different.
+
Wed Jan 14 16:30:51 2015 NARUSE, Yui <naruse@ruby-lang.org>
* lib/net/http/response.rb (Net::HTTPResponse): require one or more
diff --git a/lib/resolv.rb b/lib/resolv.rb
index a302d8a6af..73b9861078 100644
--- a/lib/resolv.rb
+++ b/lib/resolv.rb
@@ -1209,7 +1209,8 @@ class Resolv
def ==(other) # :nodoc:
return false unless Name === other
- return @labels.join == other.to_a.join && @absolute == other.absolute?
+ return false unless @absolute == other.absolute?
+ return @labels == other.to_a
end
alias eql? == # :nodoc:
diff --git a/test/resolv/test_dns.rb b/test/resolv/test_dns.rb
index 4d83d88a17..e91d127f35 100644
--- a/test/resolv/test_dns.rb
+++ b/test/resolv/test_dns.rb
@@ -175,4 +175,17 @@ class TestResolvDNS < Test::Unit::TestCase
end
end
end
+
+ def test_dots_diffences
+ name1 = Resolv::DNS::Name.create("example.org")
+ name2 = Resolv::DNS::Name.create("ex.ampl.eo.rg")
+ assert_not_equal(name1, name2, "different dots")
+ end
+
+ def test_case_insensitive_name
+ bug10550 = '[ruby-core:66498] [Bug #10550]'
+ lower = Resolv::DNS::Name.create("ruby-lang.org")
+ upper = Resolv::DNS::Name.create("Ruby-Lang.org")
+ assert_equal(lower, upper, bug10550)
+ end
end
diff --git a/version.h b/version.h
index dfad307a37..0257ef39bc 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.0.0"
#define RUBY_RELEASE_DATE "2015-01-14"
-#define RUBY_PATCHLEVEL 612
+#define RUBY_PATCHLEVEL 613
#define RUBY_RELEASE_YEAR 2015
#define RUBY_RELEASE_MONTH 1