diff options
author | matz <matz@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2006-07-24 09:28:15 +0000 |
---|---|---|
committer | matz <matz@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2006-07-24 09:28:15 +0000 |
commit | 227e7ba29cf0a029845136cadee989b6a1bb85ed (patch) | |
tree | 5a343eda29f4890682caa3e91b8bab4865a7ca09 | |
parent | d8778faa2c9e6fcc4d7bce4aaf0016496efa81df (diff) |
* process.c (rb_f_system): add security check. [ruby-talk:202947]
* process.c (rb_f_system): move signal right before fork to avoid
signal handler intervention.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@10592 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | ChangeLog | 7 | ||||
-rw-r--r-- | process.c | 3 |
2 files changed, 9 insertions, 1 deletions
@@ -1,3 +1,10 @@ +Mon Jul 24 17:55:55 2006 Yukihiro Matsumoto <matz@ruby-lang.org> + + * process.c (rb_f_system): add security check. [ruby-talk:202947] + + * process.c (rb_f_system): move signal right before fork to avoid + signal handler intervention. + Mon Jul 24 15:51:52 2006 Tanaka Akira <akr@fsij.org> * ext/readline/readline.c (readline_readline): rl_deprep_term_function @@ -1494,7 +1494,6 @@ rb_f_system(argc, argv) int i; RETSIGTYPE (*chfunc)(int); - chfunc = signal(SIGCHLD, SIG_DFL); fflush(stdout); fflush(stderr); if (argc == 0) { @@ -1516,6 +1515,8 @@ rb_f_system(argc, argv) for (i = 0; i < argc; i++) { SafeStringValue(argv[i]); } + security(RSTRING(prog ? prog : argv[0])->ptr); + chfunc = signal(SIGCHLD, SIG_DFL); retry: pid = fork(); if (pid == 0) { |