summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-03-06 08:53:51 +0000
committernaruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2019-03-06 08:53:51 +0000
commitf5452efcf863e4c15577e53c52e6e8726e70f5c4 (patch)
tree737c4f5fe79c44912f5f9ff0b4aadda7f623c2af
parentfbc070d14aead827a6d5250b36d8119e079162e0 (diff)
merge revision(s) 67167: [Backport #15635]
string.c: respect the actual encoding * string.c (rb_enc_str_coderange): respect the actual encoding of if a BOM presents, and scan for the actual code range. [ruby-core:91662] [Bug #15635] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--string.c5
-rw-r--r--test/ruby/test_m17n.rb7
-rw-r--r--version.h2
3 files changed, 11 insertions, 3 deletions
diff --git a/string.c b/string.c
index dcb28532cd..855d594b84 100644
--- a/string.c
+++ b/string.c
@@ -657,12 +657,13 @@ rb_enc_str_coderange(VALUE str)
if (cr == ENC_CODERANGE_UNKNOWN) {
int encidx = ENCODING_GET(str);
rb_encoding *enc = rb_enc_from_index(encidx);
- if (rb_enc_mbminlen(enc) > 1 && rb_enc_dummy_p(enc)) {
+ if (rb_enc_mbminlen(enc) > 1 && rb_enc_dummy_p(enc) &&
+ rb_enc_mbminlen(enc = get_actual_encoding(encidx, str)) == 1) {
cr = ENC_CODERANGE_BROKEN;
}
else {
cr = coderange_scan(RSTRING_PTR(str), RSTRING_LEN(str),
- get_actual_encoding(encidx, str));
+ enc);
}
ENC_CODERANGE_SET(str, cr);
}
diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb
index c1184c551f..75daf61376 100644
--- a/test/ruby/test_m17n.rb
+++ b/test/ruby/test_m17n.rb
@@ -269,6 +269,13 @@ class TestM17N < Test::Unit::TestCase
assert_empty(encs, bug10598)
end
+ def test_utf_without_bom_valid
+ encs = [Encoding::UTF_16, Encoding::UTF_32].find_all {|enc|
+ !(+"abcd").encode!(enc).force_encoding(enc).valid_encoding?
+ }
+ assert_empty(encs)
+ end
+
def test_object_utf16_32_inspect
EnvUtil.suppress_warning do
begin
diff --git a/version.h b/version.h
index c41e17c928..07b8633de0 100644
--- a/version.h
+++ b/version.h
@@ -1,6 +1,6 @@
#define RUBY_VERSION "2.6.1"
#define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR
-#define RUBY_PATCHLEVEL 38
+#define RUBY_PATCHLEVEL 39
#define RUBY_RELEASE_YEAR 2019
#define RUBY_RELEASE_MONTH 3