ruby.git/test/test_bundled_gems.rb, branch v3_4_9 The Ruby Programming Language Update test args with bundled gems. webrick has been removed that targets 2024-09-30T10:10:16+00:00 Hiroshi SHIBATA hsbt@ruby-lang.org 2024-09-30T10:10:16+00:00 81d26814be036a7b15c587d1e1832d9ddd24601e 






bundled_gems.rb: Add a fast path
2024-07-22T08:33:07+00:00

Jean Boussier
jean.boussier@gmail.com

2024-07-19T13:12:04+00:00

82aee1a9467c0f1bd33eb0247c5a0a8b8b9a5049

[Bug #20641] `Gem::BUNDLED_GEMS.warning?` adds a lot of extra
work on top of `require`. When the call end up atually loading code
the overhead is somewhat marginal.

However it's not uncommon for code to go some late `require` in some
paths, so it's expected that calling `require` with something already
required is somewhat fast, and `bundled_gems.rb` breaks this assumption.

To avoid this, we can have a fast path that in most case allow to
short-circuit all the heavy computations. If we extract the feature
basename and it doesn't match any of the bundled gems we care about
we can return very early.

With this change `require 'date'` is now only 1.33x slower on Ruby
3.3.3, than it was on Ruby 3.2.2, whereas before this change it
was at least 100x slower.





[Bug #20641] `Gem::BUNDLED_GEMS.warning?` adds a lot of extra
work on top of `require`. When the call end up atually loading code
the overhead is somewhat marginal.

However it's not uncommon for code to go some late `require` in some
paths, so it's expected that calling `require` with something already
required is somewhat fast, and `bundled_gems.rb` breaks this assumption.

To avoid this, we can have a fast path that in most case allow to
short-circuit all the heavy computations. If we extract the feature
basename and it doesn't match any of the bundled gems we care about
we can return very early.

With this change `require 'date'` is now only 1.33x slower on Ruby
3.3.3, than it was on Ruby 3.2.2, whereas before this change it
was at least 100x slower.