ruby.git/test/rubygems/test_gem_package_tar_reader_entry.rb, branch v3_4_9 The Ruby Programming Language [rubygems/rubygems] Fix leaked tempfiles 2023-08-19T18:02:39+00:00 Nobuyoshi Nakada nobu@ruby-lang.org 2023-08-19T12:00:19+00:00 70ce3c8947c7f95897e56b397270c061dd50f280 Fix up https://github.com/rubygems/rubygems/pull/6882 https://github.com/rubygems/rubygems/commit/525b94a89f 
Fix up https://github.com/rubygems/rubygems/pull/6882

https://github.com/rubygems/rubygems/commit/525b94a89f
[rubygems/rubygems] Raise Gem::Package::FormatError on EOF, indicating corrupt gem 2023-08-17T23:16:57+00:00 Martin Emde martin.emde@gmail.com 2023-08-15T17:39:46+00:00 e913431687f2fffb1a8cc435e60c95eea887b087 Gem::Package::TarReader::Entry now raises EOFError or returns nil appropriately based on Ruby core IO.read and IO.readpartial behavior. Zlib will respond accordingly by raising Zlib::GzipFile::Error on EOF. When verifying a gem or extracting contents, raise FormatError similar to other cases of corrupt gems. Addresses a bug where Gem::Package would attempt to call size on nil instead of raising a more descriptive and useful error, leading users to assume the problem is internal to rubygems. Remove unused error class TarReader::UnexpectedEOF that was never raised since the NoMethodError on nil would happen first. Use EOFError instead. https://github.com/rubygems/rubygems/commit/dc6129644b 
Gem::Package::TarReader::Entry now raises EOFError or returns nil
appropriately based on Ruby core IO.read and IO.readpartial behavior.

Zlib will respond accordingly by raising Zlib::GzipFile::Error on EOF.

When verifying a gem or extracting contents, raise FormatError similar
to other cases of corrupt gems.

Addresses a bug where Gem::Package would attempt to call size on nil
instead of raising a more descriptive and useful error, leading users
to assume the problem is internal to rubygems.

Remove unused error class TarReader::UnexpectedEOF that was never raised
since the NoMethodError on nil would happen first. Use EOFError instead.

https://github.com/rubygems/rubygems/commit/dc6129644b
util/rubocop -A --only Layout/EmptyLineAfterMagicComment 2023-03-23T08:18:49+00:00 Hiroshi SHIBATA hsbt@ruby-lang.org 2023-03-17T09:36:42+00:00 f24a86d83f07f214e97aa98da190cda55092805f 






util/rubocop -A --only Style/SymbolProc
2023-03-17T09:50:55+00:00

Hiroshi SHIBATA
hsbt@ruby-lang.org

2023-03-16T03:57:49+00:00

5211900d37573a82c1bdf7cb2354937cc4022ae1












[rubygems/rubygems] util/rubocop -A --only Style/CharacterLiteral
2023-03-17T09:50:55+00:00

Hiroshi SHIBATA
hsbt@ruby-lang.org

2023-03-16T05:11:12+00:00

ab644ae497a649a2f2c65d35757a19dc38518d3d

https://github.com/rubygems/rubygems/commit/aa058ff6b8





https://github.com/rubygems/rubygems/commit/aa058ff6b8







[rubygems/rubygems] Ensure that `TempIO` is closed
2023-03-09T06:19:56+00:00

Nobuyoshi Nakada
nobu@ruby-lang.org

2023-03-08T15:58:20+00:00

cf08a85b852870c7dac5936552ed3a217a758ae7

https://github.com/rubygems/rubygems/commit/dc7b9db514





https://github.com/rubygems/rubygems/commit/dc7b9db514







[rubygems/rubygems] Add TarReader::Entry#seek to seek within the tar file entry
2023-03-07T20:21:43+00:00

Martin Emde
martin.emde@gmail.com

2023-02-17T02:03:41+00:00

85a1738ab37b3348fc0b924804ca4b209f34fbf7

TarReader#each previously implemented a partial version of seek.
This code moved to Entry#seek for use from TarReader#each.

Entry#close now returns nil instead of true, like IO#close.

Closing an Entry now seeks to the end of the Entry, seeking past
any remaining zero byte tar file padding and moving the io to the
correcty position to read the next file in the archive.

Uses seek for Entry#rewind and #pos=, fixing the tar->gzip->tar nested
rewind that would break previous to this change.

Add Entry.open that behaves more like File.open.

https://github.com/rubygems/rubygems/commit/f5149565d5





TarReader#each previously implemented a partial version of seek.
This code moved to Entry#seek for use from TarReader#each.

Entry#close now returns nil instead of true, like IO#close.

Closing an Entry now seeks to the end of the Entry, seeking past
any remaining zero byte tar file padding and moving the io to the
correcty position to read the next file in the archive.

Uses seek for Entry#rewind and #pos=, fixing the tar->gzip->tar nested
rewind that would break previous to this change.

Add Entry.open that behaves more like File.open.

https://github.com/rubygems/rubygems/commit/f5149565d5







[rubygems/rubygems] Fix Tempfile leaks
2023-02-04T19:38:55+00:00

Nobuyoshi Nakada
nobu@ruby-lang.org

2023-02-03T13:29:37+00:00

e37bf46ed517c4cd74e818a1694185fb44feca72

https://github.com/rubygems/rubygems/commit/f95d1a87ce





https://github.com/rubygems/rubygems/commit/f95d1a87ce







[rubygems/rubygems] Test to show non-standard behavior of zero byte files in archive
2023-02-02T17:17:33+00:00

Martin Emde
martin.emde@gmail.com

2023-01-31T23:43:01+00:00

0853703ec6484332ef0183ebd459a8c715d36a43

Added more tests for some of the other behavior as well.
Tests were missing for readpartial with a buffer, and reading
remaining bytes after a partial read, using StringIO as reference.

https://github.com/rubygems/rubygems/commit/d600a657b1





Added more tests for some of the other behavior as well.
Tests were missing for readpartial with a buffer, and reading
remaining bytes after a partial read, using StringIO as reference.

https://github.com/rubygems/rubygems/commit/d600a657b1







RubyGems: Enable Style/StringLiterals cop
2022-07-22T03:07:23+00:00

Takuya Noguchi
takninnovationresearch@gmail.com

2022-07-17T08:08:51+00:00

d7ffd3fea402239b16833cc434404a7af82d44f3

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>





Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>