ruby.git/test/rubygems/test_gem_gem_runner.rb, branch v3_4_9

Validate user input encoding

2024-11-04T10:18:55+00:00

If the user has the encoding of her system messed up, she may end up
sending us incorrectly encoding input, causing "invalid byte sequence in
UTF-8" errors at random places.

These errors can be forced on a system without encoding issues with
something like:

```
$ gem install$(echo -e "\xFF") foo
/Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:534:in `block in set_config_file_name': invalid byte sequence in UTF-8 (ArgumentError)
	from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:530:in `each'
	from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:530:in `set_config_file_name'
	from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:177:in `initialize'
	from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/gem_runner.rb:71:in `new'
	from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/gem_runner.rb:71:in `do_configuration'
	from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/gem_runner.rb:33:in `run'
	from /Users/deivid/.asdf/installs/ruby/3.2.1/bin/gem:10:in `'
```

This commit makes RubyGems print a better error in this case:

```
$ ruby -Ilib bin/gem install$(echo -e "\xFF") foo
/Users/deivid/Code/rubygems/rubygems/lib/rubygems/gem_runner.rb:75:in `validate_encoding': invalid argument: 'install�' has invalid encoding (Gem::OptionParser::InvalidArgument)
	from /Users/deivid/Code/rubygems/rubygems/lib/rubygems/gem_runner.rb:31:in `run'
	from bin/gem:10:in `'
```

[rubygems/rubygems] Try again with https://github.com/rubygems/rubygems/pull/6693

2023-06-05T17:10:49+00:00

https://github.com/rubygems/rubygems/commit/73c0d5f059

Merge RubyGems/Bundler master from 4076391fce5847689bf2ec402b17133fe4e32285

2023-05-30T12:50:07+00:00

util/rubocop -A --only Layout/EmptyLineAfterMagicComment

2023-03-23T08:18:49+00:00

[rubygems/rubygems] Disable side-effect of GEM_HOME configuration

2023-03-10T05:16:52+00:00

https://github.com/rubygems/rubygems/commit/c43328ab03

fix test/rubygems/test_gem_package_task.rb when in -j mode

2023-02-27T21:34:27+00:00

This test skipped sometimes due to failure to load 'rake/packagetask'.
This is due to manipulation of $LOAD_PATH by other rubygems tests. If
rake is loaded before any rubygems tests run, then it works fine.

To reproduce the skipping behavior:
  $ make test-all TESTOPTS="-j6 --test-order=sorted test/rubygems/test_*.rb"

RubyGems: Enable Style/StringLiterals cop

2022-07-22T03:07:23+00:00

Signed-off-by: Takuya Noguchi

[rubygems/rubygems] Rename test/rubygems/test_{case,utilities}.rb to avoid "test_" prefix

2021-06-03T03:23:22+00:00

This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".

The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:

```
t.test_files = FileList['test/**/test_*.rb']
```

Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c682097197fee4052b47e4b4ab86562f3eaa9b, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.

Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.

https://github.com/rubygems/rubygems/commit/6460e018df

[rubygems/rubygems] Require the new files in `test/` relatively

2021-05-28T02:53:09+00:00

https://github.com/rubygems/rubygems/commit/c77868a555

Merge prepare version of RubyGems 3.2.0

2020-12-08T08:30:02+00:00