ruby.git/test/ruby, branch v3_4_3 The Ruby Programming Language merge revision(s) 3a7b9ca93b91dcc086b9ac8b9957e59268f9493b: [Backport #21217] 2025-04-14T07:21:51+00:00 Takashi Kokubun takashikkbn@gmail.com 2025-04-14T07:21:51+00:00 9abd48df705c37f69ec9fd954f84cbbbd65db624 Fix `Integer.sqrt` to never exceed actual value `Integer.sqrt` uses `sqrt(3)` from libm for small values. This method must return a value less than or equal to the actual integer square root, but libm's sqrt does not always guarantee that. This change corrects that by decrementing the result if necessary. Fixes [Bug #21217] 
	Fix `Integer.sqrt` to never exceed actual value

	`Integer.sqrt` uses `sqrt(3)` from libm for small values.
	This method must return a value less than or equal to the actual integer
	square root, but libm's sqrt does not always guarantee that.

	This change corrects that by decrementing the result if necessary.

	Fixes [Bug #21217]
Picking test fix from https://github.com/ruby/ruby/commit/3d8a66568e8106b367665d716e0d3c8c8208aa07 2025-04-03T04:45:14+00:00 Hiroshi SHIBATA hsbt@ruby-lang.org 2025-04-03T02:54:19+00:00 34e990fcec828a3e555ed353780e4e94e50b70a6 The original change is https://github.com/ruby/ruby/commit/d78ff6a767ca813ac5fa178dd7611f20a993c191 
The original change is https://github.com/ruby/ruby/commit/d78ff6a767ca813ac5fa178dd7611f20a993c191
Fix handling of `error`/`errno` in `io_internal_wait`. (#12961) 2025-03-27T22:23:31+00:00 Samuel Williams samuel.williams@oriontransfer.co.nz 2025-03-23T00:42:04+00:00 aa7380f9d8a9a37d7c4d8f827d8b119c0ffbb6f2 [Bug #21195] 
[Bug #21195]
 [Bug #21094] Update nested module names when setting temporary name 2025-03-20T16:41:35+00:00 Nobuyoshi Nakada nobu@ruby-lang.org 2025-01-29T07:55:44+00:00 5b3970f68b9108e0976b75b5d67da8c56eaa9db4 [Backport #21094] 
[Backport #21094]
[Bug #21186] multibyte char literal should be a single letter word 2025-03-20T16:38:42+00:00 Nobuyoshi Nakada nobu@ruby-lang.org 2025-03-17T12:37:00+00:00 8b491169c32621d4e74324eed08465448dfc54d5 [Backport #21186] 
[Backport #21186]
Have `ast` live longer in ISeq.compile_file to fix GC stress crash 2025-03-14T19:04:25+00:00 Alan Wu XrXr@users.noreply.github.com 2025-03-11T17:14:13+00:00 31502b0d8569b806d723a0e49a919921bf5d6e2c Previously, live range of `ast_value` ended on the call right before rb_ast_dispose(), which led to premature collection and use-after-free. We observed this crashing on -O3, -DVM_CHECK_MODE, with GCC 11.4.0 on Ubuntu. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org> 
Previously, live range of `ast_value` ended on the call right before
rb_ast_dispose(), which led to premature collection and use-after-free.

We observed this crashing on -O3, -DVM_CHECK_MODE, with GCC 11.4.0 on
Ubuntu.

Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
[Bug #19841] Refine error on marshaling recursive USERDEF 2025-03-12T17:51:50+00:00 Nobuyoshi Nakada nobu@ruby-lang.org 2023-08-20T04:04:06+00:00 ae2fcdc0f705e767045c2bd5253e8eae733d2edb 






[Bug #21163] Fix hexadecimal float conversion
2025-03-10T19:04:54+00:00

Nobuyoshi Nakada
nobu@ruby-lang.org

2025-03-04T01:22:17+00:00

e15a9044d7a9ee5435e7a6d19ef9ac46b50bb880












Replace tombstone when converting AR to ST hash
2025-03-05T23:15:45+00:00

John Hawthorn
john@hawthorn.email

2025-03-04T20:54:33+00:00

698741d73a0e6c998fb47297ce7b129366b4835b

[Bug #21170]

st_table reserves -1 as a special hash value to indicate that an entry
has been deleted. So that that's a valid value to be returned from the
hash function, do_hash replaces -1 with 0 so that it is not mistaken for
the sentinel.

Previously, when upgrading an AR table to an ST table,
rb_st_add_direct_with_hash was used which did not perform the same
conversion, this could lead to a hash in a broken state where one if its
entries which was supposed to exist being marked as a tombstone.

The hash could then become further corrupted when the ST table required
resizing as the falsely tombstoned entry would be skipped but it would
be counted in num entries, leading to an uninitialized entry at index
15.

In most cases this will be really rare, unless using a very poorly
implemented custom hash function.

This also adds two debug assertions, one that st_add_direct_with_hash
does not receive the reserved hash value, and a second in
rebuild_table_with, which ensures that after we rebuild/compact a table
it contains the expected number of elements.

Co-authored-by: Alan Wu <alanwu@ruby-lang.org>





[Bug #21170]

st_table reserves -1 as a special hash value to indicate that an entry
has been deleted. So that that's a valid value to be returned from the
hash function, do_hash replaces -1 with 0 so that it is not mistaken for
the sentinel.

Previously, when upgrading an AR table to an ST table,
rb_st_add_direct_with_hash was used which did not perform the same
conversion, this could lead to a hash in a broken state where one if its
entries which was supposed to exist being marked as a tombstone.

The hash could then become further corrupted when the ST table required
resizing as the falsely tombstoned entry would be skipped but it would
be counted in num entries, leading to an uninitialized entry at index
15.

In most cases this will be really rare, unless using a very poorly
implemented custom hash function.

This also adds two debug assertions, one that st_add_direct_with_hash
does not receive the reserved hash value, and a second in
rebuild_table_with, which ensures that after we rebuild/compact a table
it contains the expected number of elements.

Co-authored-by: Alan Wu <alanwu@ruby-lang.org>







[Bug #21159] module names should not be modifiable
2025-03-03T23:41:33+00:00

Nobuyoshi Nakada
nobu@ruby-lang.org

2025-02-27T02:07:36+00:00

ddb73fbd115631e6dec3bdd230c1cfc13027602e