ruby.git/test/monitor, branch ruby_2_7 The Ruby Programming Language new_cond before mon_initialize 2019-12-04T04:36:41+00:00 Koichi Sasada ko1@atdot.net 2019-12-04T04:36:41+00:00 c6e3db0c66312af1e932c21006437419efa9ac75 MonitorMixin#new_cond can be called before mon_initialize, so we need to initialize `@monitor` before it. https://bugs.ruby-lang.org/issues/16255#note-4 
MonitorMixin#new_cond can be called before mon_initialize, so we
need to initialize `@monitor` before it.

https://bugs.ruby-lang.org/issues/16255#note-4
Monitor#exit: check monitor ownership. 2019-11-12T01:07:45+00:00 Koichi Sasada ko1@atdot.net 2019-11-12T01:02:47+00:00 fd6445b7e8bab9d340be6f76688a8b96f1b52029 Monitor#exit should be called by only onwer Thread. However, there is not check for it. 
Monitor#exit should be called by only onwer Thread. However, there
is not check for it.
make monitor.so for performance. (#2576) 2019-10-19T19:52:20+00:00 Koichi Sasada ko1@atdot.net 2019-10-19T19:52:20+00:00 caac5f777ae288b5982708b8690e712e1cae0cf6 Recent monitor.rb has performance problem because of interrupt handlers. 'Monitor#synchronize' is frequently used primitive so the performance of this method is important. This patch rewrite 'monitor.rb' with 'monitor.so' (C-extension) and make it faster. See [Feature #16255] for details. Monitor class objects are normal object which include MonitorMixin. This patch introduce a Monitor class which is implemented on C and MonitorMixin uses Monitor object as re-entrant (recursive) Mutex. This technique improve performance because we don't need to care atomicity and we don't need accesses to instance variables any more on Monitor class. 
Recent monitor.rb has performance problem because of interrupt
handlers. 'Monitor#synchronize' is frequently used primitive
so the performance of this method is important.

This patch rewrite 'monitor.rb' with 'monitor.so' (C-extension)
and make it faster. See [Feature #16255] for details.

Monitor class objects are normal object which include MonitorMixin.
This patch introduce a Monitor class which is implemented on C
and MonitorMixin uses Monitor object as re-entrant (recursive)
Mutex. This technique improve performance because we don't need
to care atomicity and we don't need accesses to instance variables
any more on Monitor class.
 Wait for the helper thread to terminate 2019-06-28T05:54:00+00:00 Nobuyoshi Nakada nobu@ruby-lang.org 2019-06-28T05:51:23+00:00 c52dad0ecf0b8d87afb570d7dde508fe78d145d4 






lib/monitor.rb: avoid race conditions by Thread.handle_interrupt
2018-11-28T01:51:44+00:00

shugo
shugo@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2018-11-28T01:51:44+00:00

6ec1720aa38772ba4b7515790443cb578340518b

Suggested by Benoit Daloze.  [ruby-core:88502] [Bug #14998]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





Suggested by Benoit Daloze.  [ruby-core:88502] [Bug #14998]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







revert r65822
2018-11-20T03:56:51+00:00

shugo
shugo@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2018-11-20T03:56:51+00:00

0dfc5918ec19cb67d8a49915ad8ab177f56e4e73

Because mon_initialized may be used to re-initialize copied objects intentionally.

mon_initialize_spec.rb fails:

1)
MonitorMixin#mon_initialize can be called in initialize_copy to get a new Mutex and used with synchronize ERROR
ThreadError: already initialized
/home/shugo/src/ruby/lib/monitor.rb:255:in `mon_initialize'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:19:in `initialize_copy'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:28:in `initialize_dup'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:28:in `dup'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:28:in `block (2 levels) in <top (required)>'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:4:in `<top (required)>'

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65827 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





Because mon_initialized may be used to re-initialize copied objects intentionally.

mon_initialize_spec.rb fails:

1)
MonitorMixin#mon_initialize can be called in initialize_copy to get a new Mutex and used with synchronize ERROR
ThreadError: already initialized
/home/shugo/src/ruby/lib/monitor.rb:255:in `mon_initialize'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:19:in `initialize_copy'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:28:in `initialize_dup'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:28:in `dup'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:28:in `block (2 levels) in <top (required)>'
/home/shugo/src/ruby/spec/ruby/library/monitor/mon_initialize_spec.rb:4:in `<top (required)>'

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65827 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







lib/monitor.rb: prevent to initialize MonitorMixin twice
2018-11-20T03:01:55+00:00

shugo
shugo@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2018-11-20T03:01:55+00:00

8d68f422dc1a42453fabd697f004e35c618ce3ea

Suggested by Benoit Daloze.  [ruby-core:88504] [Feature #15000]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





Suggested by Benoit Daloze.  [ruby-core:88504] [Feature #15000]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







Remove unnecessary `require 'thread'`
2017-10-08T07:00:01+00:00

kazu
kazu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2017-10-08T07:00:01+00:00

6064132c42ffe99e9a0d3a6ba80a7932c6f7903d

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







Add MonitorMinx#mon_locked? and #mon_owned? to check states of objects
2017-09-20T01:40:53+00:00

shugo
shugo@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2017-09-20T01:40:53+00:00

da1b14bcec60c607bd1a6a782b44573b1fa14b52

Patched by Satoshi "Moris" Tagomori <tagomoris@gmail.com>.  [Fix GH-1699]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





Patched by Satoshi "Moris" Tagomori <tagomoris@gmail.com>.  [Fix GH-1699]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







Use qualified names
2016-08-30T06:22:30+00:00

nobu
nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2016-08-30T06:22:30+00:00

4b298ad77a8388f0aae62daeca66659a8effeade

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e