ruby.git/test/irb/test_ruby_lex.rb, branch v3_2_11 The Ruby Programming Language Drop Ruby 2.5 support 2022-11-17T04:06:32+00:00 st0012 stan001212@gmail.com 2022-07-25T22:35:25+00:00 923c1aaed7a5707d5c358627aad37f29e7738143 Because it has reached EOL for more than 1.5 years and it won't be supported by the next reline version either. 
Because it has reached EOL for more than 1.5 years and it won't be
supported by the next reline version either.
[ruby/irb] Silent the noise created when building Context in tests 2022-11-04T18:29:54+00:00 Stan Lo stan.lo@shopify.com 2022-11-04T17:53:10+00:00 367c072ac6910e487a7619f61baebe1b4a6cf315 https://github.com/ruby/irb/commit/27e4274b3c 
https://github.com/ruby/irb/commit/27e4274b3c
[ruby/irb] Provide a base test class and let tests restore encodings 2022-11-03T22:13:11+00:00 Stan Lo stan.lo@shopify.com 2022-11-03T22:13:07+00:00 a9232038119f2401e6c3d3a4946114b1e878afb5 conveniently (https://github.com/ruby/irb/pull/429) * Create a base TestIRB::TestCase class * Save/restore encodings for tests that initializes InputMethod classes Because `RelineInputMethod#initializes` calls `set_encoding`, which changes stdio/out/err and Encoding's default encoding values, we need to make sure any test that directly or indirectly (e.g. through Context) initializes `RelineInputMethod` restores encodings. `ReadlineInputMethod` also changes encodings but currently no tests cover it. * Remove unnecessary TestHelper module Since we now have a base TestCase, without_rdoc can just live there. https://github.com/ruby/irb/commit/c2874ec121 
conveniently
(https://github.com/ruby/irb/pull/429)

* Create a base TestIRB::TestCase class

* Save/restore encodings for tests that initializes InputMethod classes

Because `RelineInputMethod#initializes` calls `set_encoding`, which
changes stdio/out/err and Encoding's default encoding values, we need to
make sure any test that directly or indirectly (e.g. through Context)
initializes `RelineInputMethod` restores encodings.

`ReadlineInputMethod` also changes encodings but currently no tests
cover it.

* Remove unnecessary TestHelper module

Since we now have a base TestCase, without_rdoc can just live there.

https://github.com/ruby/irb/commit/c2874ec121
[ruby/irb] Require rubygems to run the test alone on ruby/ruby 2022-11-03T17:42:45+00:00 Takashi Kokubun takashikkbn@gmail.com 2022-11-03T17:41:57+00:00 56884b64deeeffb6400060523f8b85211ec99d78 `Gem` is not undefined on test-all https://github.com/ruby/irb/commit/08ac803d61 
`Gem` is not undefined on test-all

https://github.com/ruby/irb/commit/08ac803d61
[ruby/irb] Fix build_context for ruby/ruby CI 2022-11-03T17:35:15+00:00 Takashi Kokubun takashikkbn@gmail.com 2022-11-03T17:34:46+00:00 611b5e7f40dd7f0ee00df7981dc60890eeb2f315 Co-Authored-By: Stan Lo <stan.lo@shopify.com> https://github.com/ruby/irb/commit/d1fe234a9a 
Co-Authored-By: Stan Lo <stan.lo@shopify.com>

https://github.com/ruby/irb/commit/d1fe234a9a
[ruby/irb] Require the entire irb lib in RubyLex test 2022-11-03T17:12:35+00:00 Stan Lo stan.lo@shopify.com 2022-11-03T17:12:31+00:00 00f559641a0b4941e0022c67657469dc565ce44d (https://github.com/ruby/irb/pull/428) RubyLex is not designed to be used alone. It's usually used with an IRB context, which requires workspace. So its tests should have access to those components too. https://github.com/ruby/irb/commit/608f261da4 
(https://github.com/ruby/irb/pull/428)

RubyLex is not designed to be used alone. It's usually used with an IRB
context, which requires workspace. So its tests should have access to
those components too.

https://github.com/ruby/irb/commit/608f261da4
[ruby/irb] Refactor RubyLex and its tests 2022-11-03T16:32:22+00:00 Stan Lo stan001212@gmail.com 2022-11-03T16:32:10+00:00 c5d6a483f5f771aa904ea85dad35a368ddf8047a (https://github.com/ruby/irb/pull/427) * Make sure `RubyLex#set_input`'s context is always present in tests In real-world scenarios, the context should always be non-nil: https://github.com/ruby/irb/blob/master/lib/irb.rb#L489 So we should make sure our test setup reflects that. * Make context a required keyword Since in practice, `set_input`'s context should always be non-nil, its parameters should reflect that. And since `RubyLex#check_state` is only called by `#lex` and `#set_input`, both of which now always require context, we can assume its context should be non-nil too. https://github.com/ruby/irb/commit/1aeeb86203 
(https://github.com/ruby/irb/pull/427)

* Make sure `RubyLex#set_input`'s context is always present in tests

In real-world scenarios, the context should always be non-nil:
https://github.com/ruby/irb/blob/master/lib/irb.rb#L489

So we should make sure our test setup reflects that.

* Make context a required keyword

Since in practice, `set_input`'s context should always be non-nil, its
parameters should reflect that.

And since `RubyLex#check_state` is only called by `#lex` and
`#set_input`, both of which now always require context, we can assume
its context should be non-nil too.

https://github.com/ruby/irb/commit/1aeeb86203
[ruby/irb] Always use local variables in current context to parse code (https://github.com/ruby/irb/pull/397) 2022-10-18T05:44:07+00:00 tomoya ishida tomoyapenguin@gmail.com 2022-10-18T05:44:04+00:00 a09f764ce52838a363b006ea434287eca431dbae * Use local_variables for colorize, code_block_open check, nesting_level and assignment_expression check * Check if expression is an assignment BEFORE evaluating it. evaluate might define new localvars and change result of assignment_expression? * Add local_variables dependent code test * pend local variable dependent test on truffleruby code_block_open is not working on truffleruby * Always pass context to RubyLex#lex * Rename local_variable_assign_code generator method name * Add assignment expression truncate test * Add Context#local_variables and make generate_local_variables_assign_code more simple * Update lib/irb/input-method.rb Co-authored-by: Stan Lo <stan001212@gmail.com> * Add a comment why assignment expression check should be done before evaluate https://github.com/ruby/irb/commit/c8b3877281 Co-authored-by: Stan Lo <stan001212@gmail.com> Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com> 
* Use local_variables for colorize, code_block_open check, nesting_level and assignment_expression check

* Check if expression is an assignment BEFORE evaluating it. evaluate might define new localvars and change result of assignment_expression?

* Add local_variables dependent code test

* pend local variable dependent test on truffleruby

code_block_open is not working on truffleruby

* Always pass context to RubyLex#lex

* Rename local_variable_assign_code generator method name

* Add assignment expression truncate test

* Add Context#local_variables and make generate_local_variables_assign_code more simple

* Update lib/irb/input-method.rb

Co-authored-by: Stan Lo <stan001212@gmail.com>

* Add a comment why assignment expression check should be done before evaluate

https://github.com/ruby/irb/commit/c8b3877281

Co-authored-by: Stan Lo <stan001212@gmail.com>
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
 [ruby/irb] Fix code terminated check with heredoc and backtick (https://github.com/ruby/irb/pull/390) 2022-10-18T05:30:33+00:00 tomoya ishida tomoyapenguin@gmail.com 2022-10-18T05:30:29+00:00 344e6c915f41d99df024c7e90403baca0d5213a5 * Fix backtick method def method call handled as backtick open * Fix handling heredoc in check_string_literal * Sort result of lexer.parse by pos in ruby<2.7. It's not sorted when the given code includes heredoc. * Update lib/irb/ruby-lex.rb Co-authored-by: Stan Lo <stan001212@gmail.com> * Update lib/irb/ruby-lex.rb Co-authored-by: Stan Lo <stan001212@gmail.com> * Add check_string_literal test for heredoc code that does not end with newline https://github.com/ruby/irb/commit/44bc712460 Co-authored-by: Stan Lo <stan001212@gmail.com> 
* Fix backtick method def method call handled as backtick open

* Fix handling heredoc in check_string_literal

* Sort result of lexer.parse by pos in ruby<2.7. It's not sorted when the given code includes heredoc.

* Update lib/irb/ruby-lex.rb

Co-authored-by: Stan Lo <stan001212@gmail.com>

* Update lib/irb/ruby-lex.rb

Co-authored-by: Stan Lo <stan001212@gmail.com>

* Add check_string_literal test for heredoc code that does not end with newline

https://github.com/ruby/irb/commit/44bc712460

Co-authored-by: Stan Lo <stan001212@gmail.com>
 [ruby/irb] Fix ripper_lex_without_warning duplicated heredoc token 2022-09-30T19:17:15+00:00 tompng tomoyapenguin@gmail.com 2022-09-27T04:14:42+00:00 641310ce371bd220a5ddd5e54a86979f4055608b https://github.com/ruby/irb/commit/45b539af39 
https://github.com/ruby/irb/commit/45b539af39