ruby.git/sprintf.c, branch v4.0.4 The Ruby Programming Language Fix benign off-by-one 2024-11-09T01:39:19+00:00 John Hawthorn john@hawthorn.email 2024-10-24T05:32:55+00:00 c8c94bfb1edd6e1e045d503dfba9a96077306a27 Previously we always reserved one more byte than necessary in the sprintf output string. 
Previously we always reserved one more byte than necessary in the
sprintf output string.
Fix update_coderange for binary strings 2024-11-09T01:39:19+00:00 John Hawthorn john@hawthorn.email 2024-10-23T02:22:37+00:00 1f6dd9071c7994dd639d2e1cf2fe04e944173f17 Although a binary (aka ASCII-8BIT) string will never have a broken coderange, it still has to differentiate between "valid" and "7bit". On Ruby 3.4/trunk this problem is masked because we now clear the coderange more agressively in rb_str_resize, and we happened to always be strinking this string, but we should not assume that. On Ruby 3.3 this created strings where `ascii_only?` was true in cases it shouldn't be as well as other problems. Fixes [Bug #20883] Co-authored-by: Daniel Colson <danieljamescolson@gmail.com> Co-authored-by: Matthew Draper <matthew@trebex.net> 
Although a binary (aka ASCII-8BIT) string will never have a broken
coderange, it still has to differentiate between "valid" and "7bit".

On Ruby 3.4/trunk this problem is masked because we now clear the
coderange more agressively in rb_str_resize, and we happened to always
be strinking this string, but we should not assume that.

On Ruby 3.3 this created strings where `ascii_only?` was true in cases
it shouldn't be as well as other problems.

Fixes [Bug #20883]

Co-authored-by: Daniel Colson <danieljamescolson@gmail.com>
Co-authored-by: Matthew Draper <matthew@trebex.net>
[Bug #20873] Consider `-FIXNUM_MIN` overflow 2024-11-06T04:31:38+00:00 Nobuyoshi Nakada nobu@ruby-lang.org 2024-11-06T04:31:38+00:00 d71be7274bd2623bb521be72c245c08fc38d6ae4 `-FIXNUM_MIN` is usually greater than `FIXNUM_MAX` on platforms using two's complement representation. 
`-FIXNUM_MIN` is usually greater than `FIXNUM_MAX` on platforms using
two's complement representation.
Time#strftime: avoid repeated coderange scanning 2024-09-04T14:12:50+00:00 Jean Boussier jean.boussier@gmail.com 2024-09-04T10:52:18+00:00 294dad22d7ac5f307d567cff897507b9fd9d05e9 Followup: a3f589640fd443deea230c27efd6bdfc92f5817f Restarting scanning has a fixed cost. Since we build a string from many small parts, that causes the scan to restart many times. It's much faster to ignore the coderange, if it's needed later it will be faster to scan it in one go. ``` compare-ruby: ruby 3.4.0dev (2024-09-04T11:54:06Z opt-strftime-growth 149480f0ff) +YJIT [arm64-darwin23] built-ruby: ruby 3.4.0dev (2024-09-04T11:55:26Z opt-strftime-coder.. 29a5153cba) +YJIT [arm64-darwin23] warming up... | |compare-ruby|built-ruby| |:---------------------------|-----------:|---------:| |time.strftime("%FT%T") | 1.870M| 2.225M| | | -| 1.19x| |time.strftime("%FT%T.%3N") | 1.731M| 2.068M| | | -| 1.19x| |time.strftime("%FT%T.%6N") | 1.744M| 2.073M| | | -| 1.19x| ``` Cumulative with a3f589640fd443deea230c27efd6bdfc92f5817f: ``` compare-ruby: ruby 3.4.0dev (2024-09-04T11:55:26Z opt-strftime-coder.. 29a5153cba) +YJIT [arm64-darwin23] built-ruby: ruby 3.4.0dev (2024-09-04T12:57:30Z opt-strftime-coder.. 2b938d667a) +YJIT [arm64-darwin23] warming up... | |compare-ruby|built-ruby| |:---------------------------|-----------:|---------:| |time.strftime("%FT%T") | 1.784M| 2.277M| | | -| 1.28x| |time.strftime("%FT%T.%3N") | 1.504M| 2.056M| | | -| 1.37x| |time.strftime("%FT%T.%6N") | 1.489M| 2.094M| | | -| 1.41x| ``` 
Followup: a3f589640fd443deea230c27efd6bdfc92f5817f

Restarting scanning has a fixed cost. Since we build a string
from many small parts, that causes the scan to restart many times.

It's much faster to ignore the coderange, if it's needed later it
will be faster to scan it in one go.

```
compare-ruby: ruby 3.4.0dev (2024-09-04T11:54:06Z opt-strftime-growth 149480f0ff) +YJIT [arm64-darwin23]
built-ruby: ruby 3.4.0dev (2024-09-04T11:55:26Z opt-strftime-coder.. 29a5153cba) +YJIT [arm64-darwin23]
warming up...

|                            |compare-ruby|built-ruby|
|:---------------------------|-----------:|---------:|
|time.strftime("%FT%T")      |      1.870M|    2.225M|
|                            |           -|     1.19x|
|time.strftime("%FT%T.%3N")  |      1.731M|    2.068M|
|                            |           -|     1.19x|
|time.strftime("%FT%T.%6N")  |      1.744M|    2.073M|
|                            |           -|     1.19x|
```

Cumulative with a3f589640fd443deea230c27efd6bdfc92f5817f:

```
compare-ruby: ruby 3.4.0dev (2024-09-04T11:55:26Z opt-strftime-coder.. 29a5153cba) +YJIT [arm64-darwin23]
built-ruby: ruby 3.4.0dev (2024-09-04T12:57:30Z opt-strftime-coder.. 2b938d667a) +YJIT [arm64-darwin23]
warming up...

|                            |compare-ruby|built-ruby|
|:---------------------------|-----------:|---------:|
|time.strftime("%FT%T")      |      1.784M|    2.277M|
|                            |           -|     1.28x|
|time.strftime("%FT%T.%3N")  |      1.504M|    2.056M|
|                            |           -|     1.37x|
|time.strftime("%FT%T.%6N")  |      1.489M|    2.094M|
|                            |           -|     1.41x|
```
Do not warn about extra `format` argument when passed as keywords 2024-07-11T05:39:50+00:00 Jean Boussier jean.boussier@gmail.com 2024-06-24T13:18:14+00:00 3de0e343e27c4bbb76c3c9fda0d8be4d83807a2d [Bug #20593] It's fairly common to use `format` to interpolate a number of values into a user provided strings. The arguments not matching are a problem when they are positional, but when they are named, it's absolutely fine and we shouldn't emit a warning. 
[Bug #20593]

It's fairly common to use `format` to interpolate a number of values
into a user provided strings.

The arguments not matching are a problem when they are positional,
but when they are named, it's absolutely fine and we shouldn't
emit a warning.
[Bug #20438] Disallow "%\n" and "%\0" 2024-05-28T16:02:32+00:00 Nobuyoshi Nakada nobu@ruby-lang.org 2024-05-28T14:19:33+00:00 31c9a3a1d330606493e5e70aec3cd1a36d8c61a0 






[Bug #19167] Remove useless conversion of classes for special const
2022-12-09T13:11:44+00:00

Nobuyoshi Nakada
nobu@ruby-lang.org

2022-12-08T16:14:43+00:00

11acb7f7bcf6e80e03cf83bba863b9b3f980fdca












Using UNDEF_P macro
2022-11-16T09:58:33+00:00

S-H-GAMELINKS
gamelinks007@gmail.com

2022-11-15T04:24:08+00:00

1f4f6c9832d83e7ebd65ccf4e95cef358b3512c6












[Bug #18973] Promote US-ASCII to ASCII-8BIT when adding 8-bit char
2022-08-31T08:27:59+00:00

Nobuyoshi Nakada
nobu@ruby-lang.org

2022-08-30T09:12:08+00:00

576bdec03f0d58847690a0607c788ada433ce60f












Extract `update_coderange` macro
2022-08-31T08:27:59+00:00

Nobuyoshi Nakada
nobu@ruby-lang.org

2022-08-30T05:16:02+00:00

9dc60653db186b1ae9400ed75b413a07728ce6ff

Which restarts scanning the code range in unscanned part.





Which restarts scanning the code range in unscanned part.