ruby.git/lib/rexml/parsers/baseparser.rb, branch v2_7_8 The Ruby Programming Language Backport rexml upstream bug fixes. 2021-04-05T11:14:49+00:00 nagachika nagachika@ruby-lang.org 2021-04-05T11:14:49+00:00 b59e5a64be40b93370afbb0accfcb73c4d682045 






[ruby/rexml] Message less confusing error to human (#16)
2019-08-04T02:55:03+00:00

ujihisa
ujihisa@users.noreply.github.com

2019-02-21T08:42:08+00:00

f85caf40a69d322bde80a547e4b17568604746ff

* Message less confusing error to human

* Problem: Following error message is not helpful, because you have to reason
  that '' actually means it's in the top-level, and the 'div' (not '</div>') is
  an end tag

        require "rexml/parsers/lightparser"
        REXML::Parsers::LightParser.new('</div>').parse
        #=> Missing end tag for '' (got 'div')

* Solution: add a special case in error handling just to change the error message

        require "rexml/parsers/lightparser"
        REXML::Parsers::LightParser.new('</div>').parse
        #=> Unexpected top-level end tag (got 'div')

* Refactor by removing unnecessary `md` check

* Thanks @a_matsuda to review this at asakusa.rb!

https://github.com/ruby/rexml/commit/f6528d4477





* Message less confusing error to human

* Problem: Following error message is not helpful, because you have to reason
  that '' actually means it's in the top-level, and the 'div' (not '</div>') is
  an end tag

        require "rexml/parsers/lightparser"
        REXML::Parsers::LightParser.new('</div>').parse
        #=> Missing end tag for '' (got 'div')

* Solution: add a special case in error handling just to change the error message

        require "rexml/parsers/lightparser"
        REXML::Parsers::LightParser.new('</div>').parse
        #=> Unexpected top-level end tag (got 'div')

* Refactor by removing unnecessary `md` check

* Thanks @a_matsuda to review this at asakusa.rb!

https://github.com/ruby/rexml/commit/f6528d4477







Import REXML 3.1.9
2018-12-25T02:26:30+00:00

kou
kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2018-12-25T02:26:30+00:00

04e0609a0685b6e263ece22765ffa1393b5c54ad

It restores removed REXML::Parsers::BaseParser::UNQME_STR.
Because it's used by kramdown.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





It restores removed REXML::Parsers::BaseParser::UNQME_STR.
Because it's used by kramdown.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







rexml: upgrade to 3.1.8
2018-12-20T02:49:10+00:00

kou
kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2018-12-20T02:49:10+00:00

0d1abb904e9eda11dfed19181553725764a3d950

See https://github.com/ruby/rexml/blob/master/NEWS.md for change summary.

Changes for spec/ has been reported: https://github.com/ruby/spec/pull/639


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





See https://github.com/ruby/rexml/blob/master/NEWS.md for change summary.

Changes for spec/ has been reported: https://github.com/ruby/spec/pull/639


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







lib/*: Prefer require_relative over require.
2018-11-02T17:52:33+00:00

marcandre
marcandre@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2018-11-02T17:52:33+00:00

e859e668d2eb59f34ad18edb7458ce90076617e9

[#15206] [Fix GH-1976]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





[#15206] [Fix GH-1976]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







Add frozen_string_literal: false for all files
2015-12-16T05:07:31+00:00

naruse
naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2015-12-16T05:07:31+00:00

3e92b635fb5422207b7bbdc924e292e51e21f040

When you change this to true, you may need to add more tests.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





When you change this to true, you may need to add more tests.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







* lib/rexml/parsers/baseparser.rb
2013-08-11T09:08:21+00:00

kou
kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2013-08-11T09:08:21+00:00

3e5f5f5ca4ca2594f102832b34fc08ae82d74c23

  (REXML::Parsers::BaseParser#pull_event): Support optional NDATA
  in parameter entity declaration.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42515 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





  (REXML::Parsers::BaseParser#pull_event): Support optional NDATA
  in parameter entity declaration.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42515 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







* lib/rexml/parsers/baseparser.rb
2013-08-10T03:51:30+00:00

kou
kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2013-08-10T03:51:30+00:00

90749b1f2a87e89bd05e38f0078cf1d6eae71dc6

  (REXML::Parsers::BaseParser::CDATA_END): Use "\A" instead of "^".
  It is not an used constant but I fix it. (Or shuold I remove it?)


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42489 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





  (REXML::Parsers::BaseParser::CDATA_END): Use "\A" instead of "^".
  It is not an used constant but I fix it. (Or shuold I remove it?)


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42489 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







* lib/rexml/parsers/baseparser.rb (REXML::Parsers::BaseParser):
2013-08-10T03:48:30+00:00

kou
kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2013-08-10T03:48:30+00:00

265c2f8eb896110d93e518352a7d4254d4ab8227

  Fix wrong constant name. "]>" pattern match is the same but
  it is used for "<!DOCTYPE" end mark not "<![CDATA[" end mark.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





  Fix wrong constant name. "]>" pattern match is the same but
  it is used for "<!DOCTYPE" end mark not "<![CDATA[" end mark.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e







* lib/rexml/parsers/baseparser.rb (REXML::Parsers::BaseParser):
2013-08-10T03:46:43+00:00

kou
kou@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2013-08-10T03:46:43+00:00

43b082d90c135d45f8157fcfd1cee2fedbb5d411

  Use "\A" instead of "^" in document type declaration patterns
  because they are used as the head match in content not the head
  match in line. They don't cause any problems in the current code
  but it should be fixed.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





  Use "\A" instead of "^" in document type declaration patterns
  because they are used as the head match in content not the head
  match in line. They don't cause any problems in the current code
  but it should be fixed.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e