ruby.git/lib/irb/inspector.rb, branch v3_2_11 The Ruby Programming Language [ruby/irb] Centralize coloring control (https://github.com/ruby/irb/pull/374) 2022-06-28T13:30:42+00:00 Stan Lo stan001212@gmail.com 2022-06-28T13:30:36+00:00 44c1316293f80abaa0e76b3818322544b9372a97 * Use colorable: argument as the only coloring control * Centalize color controling logic at Color.colorable? There are 2 requirements for coloring output: 1. It's supported on the platform 2. The user wants it: `IRB.conf[:USE_COLORIZE] == true` Right now we check 1 and 2 separately whenever we colorize things. But it's error-prone because while 1 is the default of `colorable` parameter, 2 always need to manually checked. When 2 is overlooked, it causes issues like https://github.com/ruby/irb/pull/362 And there's 0 case where we may want to colorize even when the user disables it. So I think we should merge 2 into `Color.colorable?` so it can be automatically picked up. * Add tests for all inspect modes * Simplify inspectors' coloring logic * Replace use_colorize? with Color.colorable? * Remove Context#use_colorize cause it's redundant https://github.com/ruby/irb/commit/1c53023ac4 
* Use colorable: argument as the only coloring control

* Centalize color controling logic at Color.colorable?

There are 2 requirements for coloring output:

1. It's supported on the platform
2. The user wants it: `IRB.conf[:USE_COLORIZE] == true`

Right now we check 1 and 2 separately whenever we colorize things.
But it's error-prone because while 1 is the default of `colorable`
parameter, 2 always need to manually checked. When 2 is overlooked, it
causes issues like https://github.com/ruby/irb/pull/362

And there's 0 case where we may want to colorize even when the user
disables it. So I think we should merge 2 into `Color.colorable?` so it
can be automatically picked up.

* Add tests for all inspect modes

* Simplify inspectors' coloring logic

* Replace use_colorize? with Color.colorable?

* Remove Context#use_colorize cause it's redundant

https://github.com/ruby/irb/commit/1c53023ac4
[ruby/irb] Use require_relative to require lib files 2022-01-17T05:23:40+00:00 st0012 stan001212@gmail.com 2022-01-16T22:20:05+00:00 81b604fb005b2dfa9601e0dabcdacfca6d8f3fba 1. `require` can mislead Ruby to load system irb's files and cause constant redefined warnings as other code loads the same module/class from lib folder. 2. Most files already use `require_relative`. https://github.com/ruby/irb/commit/848d339f2e 
1. `require` can mislead Ruby to load system irb's files and cause
   constant redefined warnings as other code loads the same module/class
   from lib folder.
2. Most files already use `require_relative`.

https://github.com/ruby/irb/commit/848d339f2e
[ruby/irb] Make IRB::ColorPrinter.pp compatible with PP.pp 2021-01-08T06:43:40+00:00 Takashi Kokubun takashikkbn@gmail.com 2021-01-08T06:41:58+00:00 98bd7e87a08b86c7aa95502428015c3f7b4aae75 The incompatible interface is not helpful, again if you want to use it as a standalone library, falling it back to PP. Original PP.pp also ends with `out << "\n"`. https://github.com/ruby/irb/commit/4c74c7d84c 
The incompatible interface is not helpful, again if you want to use it
as a standalone library, falling it back to PP.

Original PP.pp also ends with `out << "\n"`.

https://github.com/ruby/irb/commit/4c74c7d84c
[ruby/irb] refactoring an error handling in `IRB::Inspector` 2021-01-08T04:25:18+00:00 Nobuhiro IMAI nov@yo.rim.or.jp 2021-01-07T10:21:06+00:00 ed3264d37abc54e3aade229751a9165ffd37ca2e * moved rescue clause to `#inspect_value` to catch all failures in inspectors * test with all (currently five kind of) inspect modes - tweaked the input due to only `Marshal` can inspect(dump) a `BasicObject` https://github.com/ruby/irb/commit/9d112fab8e 
* moved rescue clause to `#inspect_value` to catch all failures in inspectors
* test with all (currently five kind of) inspect modes
  - tweaked the input due to only `Marshal` can inspect(dump) a `BasicObject`

https://github.com/ruby/irb/commit/9d112fab8e
[ruby/irb] Enhance colored inspect output 2020-12-29T07:01:00+00:00 Takashi Kokubun takashikkbn@gmail.com 2020-12-29T06:16:08+00:00 c715fb46c2d8eab48323a6008c5dbca550ebe2e0 https://github.com/ruby/irb/commit/dffcdb5269 
https://github.com/ruby/irb/commit/dffcdb5269
[ruby/irb] Discard newlines at end of file 2020-08-28T02:05:18+00:00 aycabta aycabta@gmail.com 2020-08-26T10:21:24+00:00 8882927036a6630c6132f0a2067bdec64d9ca94d https://github.com/ruby/irb/commit/0b2773d91d 
https://github.com/ruby/irb/commit/0b2773d91d
[ruby/irb] Fix error when `inspect` is called but not found in inspector 2020-07-21T17:31:47+00:00 Masataka Pocke Kuwabara kuwabara@pocke.me 2020-06-10T13:01:57+00:00 b40e925c92753640ae05951fe9f69604b41fab32 https://github.com/ruby/irb/commit/ce6d53e6d9 
https://github.com/ruby/irb/commit/ce6d53e6d9
Add --colorize and --nocolorize options to IRB 2019-05-20T23:57:21+00:00 aycabta aycabta@gmail.com 2019-05-15T07:36:33+00:00 3a9008b9845db544d0788851f9527ce9f9f6bf4a 






Colorize IRB's inspect result
2019-04-25T15:47:40+00:00

Takashi Kokubun
takashikkbn@gmail.com

2019-04-25T12:36:48+00:00

b55201dd099011a22c8c1d64c653f898d9b409ca

Closes: https://github.com/ruby/ruby/pull/2150





Closes: https://github.com/ruby/ruby/pull/2150







Add frozen_string_literal: false for all files
2015-12-16T05:07:31+00:00

naruse
naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2015-12-16T05:07:31+00:00

3e92b635fb5422207b7bbdc924e292e51e21f040

When you change this to true, you may need to add more tests.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e





When you change this to true, you may need to add more tests.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e